GSoC 2021: Enhancing clang-bind#14
Open
diivm wants to merge 1 commit intoPointCloudLibrary:masterfrom
Open
Conversation
Author
|
@kunaltyagi @larshg |
larshg
reviewed
Aug 27, 2021
|
Overall it looks good. |
kunaltyagi
reviewed
Aug 30, 2021
Comment on lines
+135
to
+136
| 3. Create the API directory `build/.cmake/api/v1/query`. | ||
| 4. Create the file `build/.cmake/api/v1/query/codemodel-v2` and leave it empty. |
Member
There was a problem hiding this comment.
Perhaps a small script (in the code base and reference it here):
* Configure your project build as normal
* Run `mkdir -p .cmake/api/v1/query && touch .cmake/api/v1/query/codemodel-v2` in the root of the cmake build tree (usually the `build` folder)
* `cmake .` to reconfigure cmake
PS: Do we need the project to be built before we start working?
Author
There was a problem hiding this comment.
Do we need the project to be built before we start working?
Yes. We need both cmake-file-api and compilation db.
Member
There was a problem hiding this comment.
I meant: do we need to build PCL before starting with PCL bindings or just PCL's CMake configured?
diivm
force-pushed
the
gsoc-2021/clang-bind
branch
from
6211bfd to
77fe26d
Compare
diivm
force-pushed
the
gsoc-2021/clang-bind
branch
from
77fe26d to
8abcbb5
Compare
kunaltyagi
approved these changes
Aug 31, 2021
Member
kunaltyagi
left a comment
kunaltyagi
left a comment
There was a problem hiding this comment.
Roughly LGTM. Will merge once you're happy @divmadan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.