Skip to content

Draft: TEMP#141

Draft
nreagan wants to merge 1 commit intomasterfrom
feat/gjk-extension
Draft

Draft: TEMP#141
nreagan wants to merge 1 commit intomasterfrom
feat/gjk-extension

Conversation

@nreagan
Copy link
Copy Markdown
Collaborator

@nreagan nreagan commented Mar 29, 2026

No description provided.

@nreagan nreagan requested a review from hoffstadt as a code owner March 29, 2026 03:06
@nreagan nreagan marked this pull request as draft March 29, 2026 03:07
@nreagan
Copy link
Copy Markdown
Collaborator Author

nreagan commented Mar 29, 2026

@hoffstadt new or old! personally i think the pl_gjk_ext.* is the way to go.....I know we talked about the method in _old. but

  • i don't think it scales well, seeing as with the newer way users can define their own support functions (benefit of gjk)
  • the new method reuses shapes already defined in pl_math, instead of users having to copy over into our defined plShape struct with a type......seems like a waste of time
  • the union of shapes also made for huge mismatches in struct size between something liek a sphere, and something like a frustum

@nreagan nreagan force-pushed the feat/gjk-extension branch from 3c715f9 to 42e5300 Compare March 30, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant