Open
Conversation
Currently we manually set a number of flags for things like area damage and projectile damage for skills but a lot of these can be automated if we just map a particular stat on the gem In this case I did it for arrows on skills as there are many skills that fire arrows and manually adding the flag to every skill is laborious and error prone Many skills fire arrows which are projectiles, but not all projectiles are arrows so in the case of Thunderburst the secondary skill fire projectiles and shouldn't benefit from additional arrow mods like on Death's Harp
LocalIdentity
added
bug: behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9465
Description of the problem being solved:
Currently we manually set a number of flags for things like area damage and projectile damage for skills but a lot of these can be automated if we just map a particular stat on the gem
In this case I did it for arrows on skills as there are many skills that fire arrows and manually adding the flag to every skill is laborious and error prone
Many skills fire arrows which are projectiles, but not all projectiles are arrows so in the case of Thunderburst the secondary skill fire projectiles and shouldn't benefit from additional arrow mods like on Death's Harp
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/9w4qd0ok
Before screenshot:
After screenshot: