Add compareJewelsOfSameType option for ItemsTab#9466
Open
roychl666 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Add compareJewelsOfSameType option for ItemsTab#9466roychl666 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
roychl666 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Compare only jewels of the same type when the option is set to true. Maintain existing behavior by defaulting the option to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare only jewels of the same type when the option is set to true. Maintain existing behavior by defaulting the option to false.
This PR picks up the work started by @michelrtm in #6314. I've updated it to work with the tip of tree.
Fixes #6275.
Description of the problem being solved:
Currently, jewels (e.g., Abyss, Crimson, Cobalt, Viridian) are compared against all occupied jewel slots, including incompatible types like Cluster Jewels, which creates irrelevant data. This change introduces a toggle to ensure jewels are only compared against slots containing the same jewel type.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/6z027yW7pPix
Before screenshot:
With option default disabled.
After screenshot:
Enable the option.
