petab.calculate: compare all common columns#347
Merged
dweindl merged 2 commits intoPEtab-dev:developfrom Dec 18, 2024
Merged
Conversation
For computing residuals, ... from measurement + simulation tables, we need to match the corresponding rows. Previously, this was done using a subset of PEtab measurement table columns and checking whether all values in these columns match. This changes it to using the full set of overlapping columns, not only the known measurement columns. With that, the same functions can be used for PEtab v2 measurement/simulation tables.
dilpath
approved these changes
Dec 18, 2024
Member
dilpath
left a comment
There was a problem hiding this comment.
👍
Could make sense to only check official PEtab columns and avoid custom ones, but I don't see a reason why the custom columns would differ either, so fine 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #347 +/- ##
===========================================
- Coverage 74.67% 74.61% -0.06%
===========================================
Files 56 56
Lines 5575 5571 -4
Branches 977 978 +1
===========================================
- Hits 4163 4157 -6
- Misses 1040 1041 +1
- Partials 372 373 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For computing residuals, ... from measurement + simulation tables, we need to match the corresponding rows. Previously, this was done using a subset of PEtab measurement table columns and checking whether all values in these columns match.
This changes it to using the full set of overlapping columns, not only the known measurement columns.
With that, the same functions can be used for PEtab v2 measurement/simulation tables.