Fix np.where on scalar boolean in EngineMass#1054
Open
bdphilli wants to merge 2 commits intoOpenMDAO:mainfrom
Open
Fix np.where on scalar boolean in EngineMass#1054bdphilli wants to merge 2 commits intoOpenMDAO:mainfrom
bdphilli wants to merge 2 commits intoOpenMDAO:mainfrom
Conversation
np.where(scale_mass) fails when scale_mass is a 0-d array or scalar boolean (NumPy deprecation). Wrap in np.atleast_1d() in both compute() and compute_partials() so indexing works regardless of input dimensionality.
ehariton
approved these changes
Mar 31, 2026
Member
|
Looking into this being a deeper bug in the pre-processors, as the SCALE_MASS option should have been turned into a list. |
jkirk5
requested changes
Apr 2, 2026
Contributor
jkirk5
left a comment
jkirk5
left a comment
There was a problem hiding this comment.
I'd like to test an example case that replicates the issue and try and debug from the source (preprocessor failure?) first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.where(scale_mass) fails when scale_mass is a 0-d array or scalar boolean (NumPy deprecation). Wrap in np.atleast_1d() in both compute() and compute_partials() so indexing works regardless of input dimensionality.