fix: show loading state when switching adaptor docs#4462
Open
fix: show loading state when switching adaptor docs#4462
Conversation
The useDocs hook didn't reset docs state to null when fetching a new uncached adaptor, so the panel showed stale docs from the previous adaptor until the new ones loaded.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4462 +/- ##
==========================================
- Coverage 89.47% 89.42% -0.06%
==========================================
Files 425 425
Lines 20213 20213
==========================================
- Hits 18086 18075 -11
- Misses 2127 2138 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the docs panel showing stale content when switching a job's adaptor. The
useDocshook didn't reset its state tonull(loading) when fetching a new uncached adaptor, so the previous adaptor's docs stayed visible until the new ones loaded.Closes #4461
Validation steps
Additional notes for the reviewer
AI Usage
Pre-submission checklist
/reviewwith Claude Code):owner,:admin,:editor,:viewer)