Skip to content

fix: remove duplicate heading on login page#4460

Merged
taylordowns2000 merged 3 commits intomainfrom
fix/duplicate-login-heading
Feb 28, 2026
Merged

fix: remove duplicate heading on login page#4460
taylordowns2000 merged 3 commits intomainfrom
fix/duplicate-login-heading

Conversation

@elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Feb 25, 2026

Description

This PR fixes a duplicate "Log in" heading on the login page. The LayoutComponents.header component rendered two independent <h1> elements — one for the no-breadcrumbs case and another for the no-current_user case. On the login page both conditions were true, causing the title to appear twice. The fix merges them into a single <h1> with conditional styling.

Closes #4459

Validation steps

  1. Visit /users/log_in while logged out; verify only one "Log in" heading appears (large, bold)
  2. Visit any authenticated page with breadcrumbs; verify breadcrumbs render normally
  3. Visit an authenticated page without breadcrumbs; verify the title renders once in the smaller style

Additional notes for the reviewer

AI Usage

  • I have used Claude Code
  • I have used another model
  • I have not used AI

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

The header component rendered two independent <h1> elements — one when
there were no breadcrumbs and another when there was no current_user.
On the login page both conditions were true, causing the title to appear
twice. Merge them into a single <h1> with conditional styling.
@taylordowns2000 taylordowns2000 merged commit 1f0ea49 into main Feb 28, 2026
1 check was pending
@taylordowns2000 taylordowns2000 deleted the fix/duplicate-login-heading branch February 28, 2026 00:57
@github-project-automation github-project-automation bot moved this from New Issues to Done in Core Feb 28, 2026
@taylordowns2000 taylordowns2000 removed the request for review from theroinaochieng February 28, 2026 00:57
@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (14c67e9) to head (c5d6b92).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4460      +/-   ##
==========================================
- Coverage   89.35%   89.32%   -0.04%     
==========================================
  Files         425      425              
  Lines       20222    20221       -1     
==========================================
- Hits        18069    18062       -7     
- Misses       2153     2159       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix duplicate 'Log in' heading on login page

2 participants