fix: remove duplicate heading on login page#4460
Merged
taylordowns2000 merged 3 commits intomainfrom Feb 28, 2026
Merged
Conversation
The header component rendered two independent <h1> elements — one when there were no breadcrumbs and another when there was no current_user. On the login page both conditions were true, causing the title to appear twice. Merge them into a single <h1> with conditional styling.
taylordowns2000
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4460 +/- ##
==========================================
- Coverage 89.35% 89.32% -0.04%
==========================================
Files 425 425
Lines 20222 20221 -1
==========================================
- Hits 18069 18062 -7
- Misses 2153 2159 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a duplicate "Log in" heading on the login page. The
LayoutComponents.headercomponent rendered two independent<h1>elements — one for the no-breadcrumbs case and another for the no-current_usercase. On the login page both conditions were true, causing the title to appear twice. The fix merges them into a single<h1>with conditional styling.Closes #4459
Validation steps
/users/log_inwhile logged out; verify only one "Log in" heading appears (large, bold)Additional notes for the reviewer
AI Usage
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)