Skip to content

Fix: prevent side panel from covering IDE when creating workflow with template#4457

Open
lmac-1 wants to merge 3 commits intomainfrom
4347-workflow-creation-bugs
Open

Fix: prevent side panel from covering IDE when creating workflow with template#4457
lmac-1 wants to merge 3 commits intomainfrom
4347-workflow-creation-bugs

Conversation

@lmac-1
Copy link
Collaborator

@lmac-1 lmac-1 commented Feb 25, 2026

Description

Previously, SIDE_PANEL was at z-60 which covered the IDE at z-50, making it impossible to view job code when creating workflows from templates.

Lowering to z-30 is safe because:

  • No UI elements exist between z-30 and z-50 that could conflict
  • Template sidebar and AI assistant panel are mutually exclusive (they close each other when opened, so can't overlap)
  • Side panels still correctly appear above canvas elements (z-5 to z-20)

This establishes the correct layering hierarchy:
Canvas (5-20) < Side panels (30) < IDE/Modals (50)

Closes #4347

Validation steps

  1. Click "Create a new workflow" from Workflows page
  2. Choose a template
  3. Inspect the code of one of the steps

Before this PR it looked like this:
image

Expected: Code now sits on top of the sidebar rather than underneath

Additional notes for the reviewer

  1. In the original issue there was also an error when you closed the AI assistant by the top right button, that it complained the job didn't exist. This has been fixed by something else since raising.
  2. This PR made me realise that we have constants for z-index in the project. We definitely aren't using these and could be a potential clean up issue for a rainy day.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

Previously, SIDE_PANEL was at z-60 which covered the IDE at z-50,
making it impossible to view job code when creating workflows from
templates.

Lowering to z-30 is safe because:
- IDE and modals (z-50) now correctly appear above side panels
- No UI elements exist between z-30 and z-50 that could conflict
- Template sidebar and AI assistant panel are mutually exclusive
  (they close each other when opened, so can't overlap)
- Side panels still correctly appear above canvas elements (z-5 to z-20)

This establishes the correct layering hierarchy:
  Canvas (5-20) < Side panels (30) < IDE/Modals (50)
@github-project-automation github-project-automation bot moved this to New Issues in Core Feb 25, 2026
@lmac-1 lmac-1 changed the title Fix: Workflow Creation via Template hides job code Fix: prevent side panel from covering IDE when creating workflow with template Feb 25, 2026
@lmac-1 lmac-1 requested review from elias-ba and theroinaochieng and removed request for doc-han February 26, 2026 09:24
@lmac-1
Copy link
Collaborator Author

lmac-1 commented Feb 26, 2026

Removing @doc-han as a reviewer and adding @elias-ba to review instead.

@elias-ba it's a small change, but you were the one who created the z-index constants file, so I think it makes sense for you to review. As I mentioned in the notes, it seems like we aren't using this file as we should and could be cleaned up for a rainy day later in the future, but would need solid regression testing.

Copy link
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lmac-1 this great! It's a clean and well-scoped fix. The z-index hierarchy Canvas (5-20) < Side panels (30) < IDE/Modals (50) makes sense.

One note for a future cleanup: there are ~15 hardcoded z-50/z-[60] values across the collaborative editor that don't use the Z_INDEX constants. Migrating those would help prevent this kind of layering issue from recurring, but that's a separate task, not a blocker here.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.39%. Comparing base (1f0ea49) to head (083d02e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4457      +/-   ##
==========================================
- Coverage   89.42%   89.39%   -0.04%     
==========================================
  Files         425      425              
  Lines       20221    20221              
==========================================
- Hits        18083    18076       -7     
- Misses       2138     2145       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Workflow Creation via Template hides job code

2 participants