Conversation
aashish24
left a comment
There was a problem hiding this comment.
code looks reasonable to me 👍 I am wondering if we should just call the model RPCModel instead of RPC_Model?
Also, do we have some test data that we can use to add testing for the model? also perhaps later we can create a general transform model for geospatial.
|
Yes, we can easily make up some test data, but I'm not sure where to put it or how tests are structured in gaia. |
|
thanks for the changes. The tests are python unit tests. |
aashish24
left a comment
There was a problem hiding this comment.
thanks for fixing the style as well. LGTM if we add the tests later in a separate PR.
|
Yes, can you have Dan help by adding the tests. I won't have time to get to it for a while. I'll send you some data. |
No description provided.