feat(chatbot): separate answer instructions from prompt matching (#376)#795
Open
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Open
feat(chatbot): separate answer instructions from prompt matching (#376)#795PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #376
This PR implements issue #376 by separating answer instructions from the user prompt so OpenCRE matching quality is not degraded by language/style directives.
Problem
Previously, language/style directives (for example, "Answer in Chinese") were included in the same prompt text used for embeddings and matching. That made retrieval less accurate.
Changes
Instructionsinput in chatbot UI (default:Answer in English)/rest/v1/completionnow receivespromptandinstructionsseparatelypromptonlyinstructionsare applied only to final answer generationapplication/tests/prompt_client_test.pyapplication/tests/web_main_test.py::TestMain::test_completion_passes_instructions_separatelyVerification
venv/bin/python -m pytest application/tests/prompt_client_test.py application/tests/web_main_test.py::TestMain::test_completion_passes_instructions_separately -qyarn build(frontend build passes; only existing webpack size warnings)