Make map element work

[rimi-itk]

https://os2forms-leantime.itkdev.dk/_#/tickets/showTicket/180

Makes the map element work by adding “Zoom control position” to map element – Leaflet seems to require this setting. Also removes reference to nonexistent CSS file.

Before

The Browser console reports

Uncaught TypeError: can't access property "indexOf", i is undefined
    addTo Control.js:76
    addControl Control.js:137
    setPosition Control.js:52
    initialise leaflet.drupal.js:278
    Leaflet leaflet.drupal.js:225
    loadMap leaflet.drupal.js:23
    attach leaflet.drupal.js:193
    attach leaflet.drupal.js:15
    each jQuery
    attach leaflet.drupal.js:10
    attachBehaviors drupal.js:166
    attachBehaviors drupal.js:162
    insert ajax.js:1404
    jQuery 2
    insert ajax.js:1396
    commandExecutionQueue ajax.js:1046
    promise callback*Drupal.Ajax.prototype.commandExecutionQueue/< ajax.js:1039
    commandExecutionQueue ajax.js:1036
    success ajax.js:1095
    processReplacement big_pipe.js:84
    checkMutationAndProcess big_pipe.js:110
    processMutations big_pipe.js:134
    processMutations big_pipe.js:133
    MutationCallback* big_pipe.js:150
    <anonymous> big_pipe.js:184
Control.js:76:33

After

Important

The failing checks are not related to changes in this pull request. Somebody has to clean up the checks to make them work again. #290 has been created to hopefully address this.

[Anna-itk]

@ds-bellcom kan Jørn eller Stan hjælpe med et review på denne?

[skifter]

Hei @Anna-itk - it is planned this week. I do not know the exact date. @ds-bellcom

[stankut]

since one of the main ideas of this PR was to get rid of defining the constants more than once, I though this would be a good place to reuse the already defined constants.
However these contstants are defined as private. Maybe in the future we can consider adding extra abstraction level - e.g. interface just for that.

but it's a minor thing, i think it's also fine as it is.