[HYRAX-1868] Turn Checksums on all the time the NGAP service.#242
Merged
ndp-opendap merged 3 commits intomasterfrom Sep 9, 2025
Merged
[HYRAX-1868] Turn Checksums on all the time the NGAP service.#242ndp-opendap merged 3 commits intomasterfrom
ndp-opendap merged 3 commits intomasterfrom
Conversation
Contributor
|
My understanding is that checksums will be set to True by default on NGAP. That is ok with me... How much of NASA data NGAP covers? This may or may not break the pydap (dap4) client. Also - all these changes make this draft PR even more important |
hannahilea
changed the title
|
hannahilea
reviewed
Sep 9, 2025
Collaborator
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
Great, looks good to me! Kicking off a test-deploy SIT test now.
hannahilea
approved these changes
Sep 9, 2025
Collaborator
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
Tested on SIT; test details in HYRAX ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will break the getdap4 client.