Specify that the computation of checksums includes counts.#35
Open
DennisHeimbigner wants to merge 1 commit intomainfrom
Open
Specify that the computation of checksums includes counts.#35DennisHeimbigner wants to merge 1 commit intomainfrom
DennisHeimbigner wants to merge 1 commit intomainfrom
Conversation
Modify the checksum section to add a specific subsection on how the checksum is computed. This specifies that the computation specifically include the counts for variable-length data (Strings, Sequences, and Structs with variable-length fields).
Collaborator
|
I agree that it is important to be more explicit about how dap4-specification/01_data-model-and-serialized-rep.adoc Lines 1737 to 1740 in 406ab93 The current text does not mention |
Collaborator
Author
|
I think that text is referring to the chunked format counts as opposed to the internal sequence and string counts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: Issue #33
re: Discussion #6
re: PR #34
Modify the checksum section to add a specific subsection on how the checksum is computed. This specifies that the computation specifically include the counts for variable-length data (Strings, Sequences, and Structs with variable-length fields).