Added LAN8670_Read_PHY_ID1() and LAN8670_Read_Model_Number() to LAN8670 PHY Driver#370
Merged
bjackson312006 merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds two new debugging helper functions to the LAN8670 PHY driver that read hardware identification registers with known values, making it easier to verify proper communication with the device.
Changes:
- Added
LAN8670_Read_PHY_ID1()to read the 16-bit PHY Identifier 1 register containing the first half of the OUI (expected value: 0x0007) - Added
LAN8670_Read_Model_Number()to read the 6-bit model number field from the PHY Identifier 2 register (expected value: 0x16 for LAN8670)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| general/src/lan8670.c | Implements the two new register read functions with proper error handling following established patterns |
| general/include/lan8670.h | Declares the new functions with Doxygen documentation describing their purpose and expected values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
caiodasilva2005
approved these changes
Feb 16, 2026
Contributor
caiodasilva2005
left a comment
There was a problem hiding this comment.
I will figure out why clang format is failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
LAN8670_Read_PHY_ID1()andLAN8670_Read_Model_Number()to the LAN8670 PHY driver. These functions should be helpful for debugging, since these register fields have known values.