Skip to content

Use cmake-rn #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kraenhansen wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use cmake-rn #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d85889
Add dependency on cmake-rn
Oct 24, 2025
82d0dde
Use CMAKE_OSX_SYSROOT to determine TARGET_PLATFORM
Oct 24, 2025
8d391e2
Refactor build_nativescript.sh to call cmake-rn instead of creating f…
Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions NativeScript/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ set(TARGET_ENGINE "v8" CACHE STRING "Target JS engine for the NativeScript runti
set(METADATA_SIZE 0 CACHE STRING "Size of embedded metadata in bytes")
set(BUILD_CLI_BINARY OFF CACHE BOOL "Build the NativeScript CLI binary")

if(CMAKE_OSX_SYSROOT STREQUAL "iphoneos")
set(TARGET_PLATFORM "ios")
elseif(CMAKE_OSX_SYSROOT STREQUAL "iphonesimulator")
set(TARGET_PLATFORM "ios-sim")
elseif(CMAKE_OSX_SYSROOT STREQUAL "macosx")
set(TARGET_PLATFORM "macos")
endif()

if(TARGET_PLATFORM STREQUAL "ios")
set(CMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET "13.0")
set(CMAKE_XCODE_ATTRIBUTE_TARGETED_DEVICE_FAMILY "1,2")
Expand Down Expand Up @@ -305,16 +313,16 @@ if(TARGET_PLATFORM_MACOS)

# Convert the Info.plist from binary format to XML format.
# This seemed to unblock a build error when using in React Native.
add_custom_command(TARGET ${NAME} POST_BUILD
COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Resources/Info.plist
)
# add_custom_command(TARGET ${NAME} POST_BUILD
# COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Resources/Info.plist
# )
set(METADATA_FILE "metadata.macos.nsmd")
elseif(TARGET_PLATFORM_IOS)
# Convert the Info.plist from binary format to XML format.
# This seemed to unblock a build error when using in React Native.
add_custom_command(TARGET ${NAME} POST_BUILD
COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Info.plist
)
# add_custom_command(TARGET ${NAME} POST_BUILD
# COMMAND plutil -convert xml1 $<TARGET_FILE_DIR:${NAME}>/Info.plist
# )

if(TARGET_PLATFORM_SIM)
set(METADATA_FILE "metadata.ios-sim.nsmd")
Expand Down
104 changes: 61 additions & 43 deletions build_nativescript.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,43 +79,60 @@ function cmake_build () {
cmake --build $DIST/intermediates/$platform --config $CONFIG_BUILD
}

TRIPLETS=()

if $BUILD_CATALYST; then
checkpoint "Building NativeScript for Mac Catalyst"

# cmake_build catalyst x86_64 arm64

fi

if $BUILD_SIMULATOR; then
checkpoint "Building NativeScript for iPhone (simulator)"
if [[ $BUILD_SIMULATOR && "$TARGET_ENGINE" == "none" ]]; then
# TODO: Add x86_64-apple-ios-sim once supported
TRIPLETS+=("arm64-apple-ios-sim")
elif $BUILD_SIMULATOR; then
checkpoint "Building NativeScript for iPhone (simulator)"

cmake_build ios-sim x86_64 arm64
cmake_build ios-sim x86_64 arm64
Comment on lines -89 to +97
Copy link
Collaborator

@shirakaba shirakaba Feb 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, cmake_build would be run for each platform, like this:

# Conditions for this example:
BUILD_IPHONE=true
BUILD_SIMULATOR=true
EMBED_METADATA=true
TARGET_ENGINE=none

# (1) Result of calling `cmake_build ios-sim x86_64 arm64`:
# (1a) Generate intermediate project
cmake \
  --source=./NativeScript \
  --build=dist/intermediates/ios-sim \
  -GXcode \
  -DTARGET_PLATFORM=ios-sim \
  -DTARGET_ENGINE=none \
  -DMETADATA_SIZE=1234 \
  -DBUILD_CLI_BINARY=false

# (1b) Build intermediate project
cmake \
  --build dist/intermediates/ios-sim \
  --config RelWithDebInfo

# (2) Result of calling `cmake_build ios arm64`:
# (2a) Generate intermediate project
cmake \
  --source=./NativeScript \
  --build=dist/intermediates/ios \
  -GXcode \
  -DTARGET_PLATFORM=ios \
  -DTARGET_ENGINE=none \
  -DMETADATA_SIZE=1234 \
  -DBUILD_CLI_BINARY=false

# (2b) Build intermediate project
cmake \
  --build dist/intermediates/ios \
  --config RelWithDebInfo

# etc.

We still need to preserve that behaviour for React Native builds, i.e. TARGET_ENGINE=none, with any value of EMBED_METADATA (EMBED_METADATA may be true or false, depending on whether we want to provide metadata for the whole iOS SDK up-front, or let users generate it at app build time so that it can be specific to the code that their project is linking).

When using cmake-rn with TRIPLETS, I'm not clear how we can:

  1. In step a, separately specify the metadata size for each platform in the triplet (as it will indeed differ by platform)
  2. In step b, build the intermediate project for each triplet.

How can we solve that?


fi

if $BUILD_IPHONE; then
checkpoint "Building NativeScript for iPhone (physical)"
if [[ $BUILD_IPHONE && "$TARGET_ENGINE" == "none" ]]; then
TRIPLETS+=("arm64-apple-ios")

elif $BUILD_IPHONE; then
checkpoint "Building NativeScript for iPhone (physical)"

cmake_build ios arm64
cmake_build ios arm64

fi

if $BUILD_MACOS; then
checkpoint "Building NativeScript for macOS"
if [[ $BUILD_MACOS && "$TARGET_ENGINE" == "none" ]]; then
TRIPLETS+=("arm64;x86_64-apple-darwin")

cmake_build macos x86_64 arm64
elif $BUILD_MACOS; then
checkpoint "Building NativeScript for macOS"
cmake_build macos x86_64 arm64

fi

if $BUILD_VISION; then
if [[ $BUILD_VISION && "$TARGET_ENGINE" == "none" ]]; then
# TRIPLETS+=("arm64-apple-visionos")
# TODO: Add x86_64-apple-visionos-sim once supported
# TRIPLETS+=("x86_64-apple-visionos-sim")
# TRIPLETS+=("arm64-apple-visionos-sim")
echo "Skipping visionOS prebuilds for React Native Node-API as they are not yet supported."

elif $BUILD_VISION; then

checkpoint "Building NativeScript for visionOS (physical)"
checkpoint "Building NativeScript for visionOS (physical)"

# cmake_build visionos arm64
# cmake_build visionos arm64

checkpoint "Building NativeScript for visionOS (simulator)"
checkpoint "Building NativeScript for visionOS (simulator)"

# cmake_build visionos-sim x86_64 arm64
# cmake_build visionos-sim x86_64 arm64

fi

Expand Down Expand Up @@ -151,45 +168,46 @@ if $BUILD_VISION; then
-debug-symbols "$DIST/intermediates/visionos-sim/$CONFIG_BUILD-xros/NativeScript.framework.dSYM" )
fi

if [[ -n "${XCFRAMEWORKS[@]}" ]]; then
if [[ "$TARGET_ENGINE" == "none" ]]; then
checkpoint "Creating the XCFramework for iOS (NativeScript.apple.node)"

# We adhere to the prebuilds standard as described here:
# https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md
OUTPUT_DIR="packages/ios/build/$CONFIG_BUILD/NativeScript.apple.node"
rm -rf $OUTPUT_DIR
deno run -A ./scripts/build_xcframework.mts --output "$OUTPUT_DIR" ${XCFRAMEWORKS[@]}
else
checkpoint "Creating NativeScript.xcframework"

OUTPUT_DIR="$DIST/NativeScript.xcframework"
rm -rf $OUTPUT_DIR
xcodebuild -create-xcframework ${XCFRAMEWORKS[@]} -output "$OUTPUT_DIR"
fi
if [[ -n "${XCFRAMEWORKS[@]}" && "$TARGET_ENGINE" != "none" ]]; then
checkpoint "Creating NativeScript.xcframework"

OUTPUT_DIR="$DIST/NativeScript.xcframework"
rm -rf $OUTPUT_DIR
xcodebuild -create-xcframework ${XCFRAMEWORKS[@]} -output "$OUTPUT_DIR"
fi

if [[ -n "${TRIPLETS[@]}" && "$TARGET_ENGINE" == "none" ]]; then
checkpoint "Building NativeScript prebuilt for React Native Node-API (NativeScript.apple.node)"

TRIPLET_ARGS=()
for triplet in "${TRIPLETS[@]}"; do
TRIPLET_ARGS+=(--triplet "$triplet")
done

# We adhere to the prebuilds standard as described here:
# https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md
OUTPUT_DIR="packages/ios/build/$CONFIG_BUILD"
cmake-rn --source ./NativeScript --build "$DIST/intermediates" --out "$OUTPUT_DIR" -D TARGET_ENGINE=$TARGET_ENGINE "${TRIPLET_ARGS[@]}"
fi

# We're currently distributing two separate packages:
# 1. UIKit-based (@nativescript/ios-node-api)
# 2. AppKit-based (@nativescript/macos-node-api)
# As such, there's no point bundling both UIKit-based and AppKit-based into a
# single XCFramework.
if $BUILD_MACOS; then
if [[ $BUILD_MACOS && "$TARGET_ENGINE" == "none" ]]; then
checkpoint "Creating the XCFramework for macOS (NativeScript.apple.node)"

OUTPUT_DIR="packages/macos/build/$CONFIG_BUILD"
cmake-rn --source ./NativeScript --build "$DIST/intermediates" --out "$OUTPUT_DIR" -D TARGET_ENGINE=$TARGET_ENGINE --triplet 'arm64;x86_64-apple-darwin'

elif $BUILD_MACOS; then
XCFRAMEWORKS=( -framework "$DIST/intermediates/macos/$CONFIG_BUILD/NativeScript.framework"
-debug-symbols "$DIST/intermediates/macos/$CONFIG_BUILD/NativeScript.framework.dSYM" )

if [[ "$TARGET_ENGINE" == "none" ]]; then
checkpoint "Creating the XCFramework for macOS (NativeScript.apple.node)"

# We adhere to the prebuilds standard as described here:
# https://github.com/callstackincubator/react-native-node-api/blob/9b231c14459b62d7df33360f930a00343d8c46e6/docs/PREBUILDS.md
OUTPUT_DIR="packages/macos/build/$CONFIG_BUILD/NativeScript.apple.node"
rm -rf $OUTPUT_DIR
deno run -A ./scripts/build_xcframework.mts --output "$OUTPUT_DIR" ${XCFRAMEWORKS[@]}
else
checkpoint "Creating NativeScript.node for macOS"
cp -r "$DIST/intermediates/macos/$CONFIG_BUILD/libNativeScript.dylib" "$DIST/NativeScript.node"
fi

checkpoint "Creating NativeScript.node for macOS"
cp -r "$DIST/intermediates/macos/$CONFIG_BUILD/libNativeScript.dylib" "$DIST/NativeScript.node"
fi

if $BUILD_MACOS_CLI; then
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
},
"license": "Apache-2.0",
"devDependencies": {
"cmake-rn": "^0.5.1",
"conventional-changelog-cli": "^2.1.1",
"dayjs": "^1.11.7",
"husky": "^9.0.11",
Expand Down
124 changes: 0 additions & 124 deletions scripts/build_xcframework.mts
View file
Open in desktop

This file was deleted.