fix: update digest lookup to use versioned RepoTags instead of latest by shivakunv · Pull Request #1935 · NVIDIA/gpu-operator

shivakunv · 2025-11-24T18:37:21Z

Current Issue:
Renovate always pulls the digest from the latest tag, which results in a SHA difference.
However, the version in the values.yaml file is not updated in this scenario, so the digest in the manifests becomes mismatched and stale.

Solution:
Open a PR only when the RepoTags value in values.yaml changes.
Then search for that exact digest in
bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml
instead of using the digest from latest.

check open PRs:
https://github.com/shivakunv/gpu-operator-shiva/pulls

shivakunv · 2025-11-24T18:38:45Z

PTAL @cdesiniotis @tariq1890

coveralls · 2025-11-24T18:43:35Z

coverage: 26.155%. remained the same
when pulling 2f55809 on grouptagcommitwithbundle
into 69ba9c3 on main.

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml

rajathagasthya

This largely looks good to me. Just a couple of questions.

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml

.github/renovate.json

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml

.github/renovate.json

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml

shivakunv · 2025-12-20T03:20:50Z

PTAL @tariq1890
Since @cdesiniotis has already confirmed that this image tagging convention will work, the renovate.json file will not impact our build process.

Regarding this section:

- name: vfio-manager-image
   image: ghcr.io/nvidia/k8s-driver-manager:0d30fa9c

I have only added TODO comments.

cdesiniotis · 2026-01-08T23:17:06Z

@shivakunv I took a look at some of the sample PRs raised in your fork, and I noticed that only one line gets updated in the bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml (the CSV file). Note, that for each container image in the CSV file, there are two lines that need to be updated. For example, for dcgm-exporter, both this line and this line need to be updated. Can you confirm that renovate is updating both occurrences? Do you have an example PR that demonstrates this?

shivakunv · 2026-01-09T10:40:41Z

@shivakunv I took a look at some of the sample PRs raised in your fork, and I noticed that only one line gets updated in the bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml (the CSV file). Note, that for each container image in the CSV file, there are two lines that need to be updated. For example, for dcgm-exporter, both this line and this line need to be updated. Can you confirm that renovate is updating both occurrences? Do you have an example PR that demonstrates this?

@cdesiniotis Thanks!!
I got carried away by too many changes and accidently removed a required change.
I have corrected it now and updated the code.

Please check my repo PRs opened by renovate:
https://github.com/shivakunv/gpu-operator-shiva/pulls

cdesiniotis · 2026-01-10T00:19:30Z

https://github.com/shivakunv/gpu-operator-shiva/pulls

I see two PRs raised today, https://github.com/shivakunv/gpu-operator-shiva/pull/233 and https://github.com/shivakunv/gpu-operator-shiva/pull/232. Both of these PRs only update the helm values, and not the CSV file.

shivakunv · 2026-01-10T03:55:28Z

https://github.com/shivakunv/gpu-operator-shiva/pulls

I see two PRs raised today, shivakunv/gpu-operator-shiva#233 and shivakunv/gpu-operator-shiva#232. Both of these PRs only update the helm values, and not the CSV file.

@cdesiniotis
Renovate properties show an older date if we had opened the same package PR earlier.
If you open these PR link (e.g. https://github.com/shivakunv/gpu-operator-shiva/pull/220), you will see that Renovate closes the existing PR and opens a new one.

Please check the snippets below for PR: https://github.com/shivakunv/gpu-operator-shiva/pull/220

.github/renovate.json

rahulait · 2026-02-11T18:58:49Z

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml

    # TODO: update to a k8s-driver-manager image from nvcr.io once the next version is published
+    # TODO: Add Renovate rule to update this image to the values.yaml image
    - name: vfio-manager-image
      image: ghcr.io/nvidia/k8s-driver-manager:69eec274


Can we use the k8s-driver-manager image and tag from values.yaml here? Not sure why we want to keep it as TODO here.

@cdesiniotis has intentionally added this for k8s-driver-image.
We need clarification from Chris.
should I update it @cdesiniotis ?

Right now, the vfio-manager image in both the CSV and values file is pointing to a pre-release image on ghcr.io. Once the next version of the k8s-driver-manager is released, we will update the CSV and values file to point to the released image on nvcr.io.

rahulait · 2026-02-11T18:59:36Z

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml

                  # TODO: update to a k8s-driver-manager image from nvcr.io once the next version is published
+                  # Add Renovate rule to update this image to the values.yaml image
                  - name: "VFIO_MANAGER_IMAGE"
                    value: "ghcr.io/nvidia/k8s-driver-manager:69eec274"


refer last comment

.github/renovate.json

rahulait · 2026-02-11T20:00:49Z

Other than few minor comments, the PR looks good to me.

.github/renovate.json

rahulait

LGTM

Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com> Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>

cdesiniotis · 2026-02-26T17:51:14Z

deployments/gpu-operator/values.yaml

  repository: nvcr.io/nvidia/cloud-native
  image: dcgm
-  version: 4.5.2-1-ubuntu22.04
+  version: 4.5.2-1-ubi9


Why was this change made?

Is this so that the image in the CSV file and helm values are identical, and therefore, renovate can update them simaltaneously?

yes.
refer : #1935 (comment)

shivakunv force-pushed the grouptagcommitwithbundle branch from deb4294 to e789ee7 Compare November 24, 2025 18:37

shivakunv marked this pull request as ready for review November 24, 2025 18:38

shivakunv requested review from ArangoGutierrez, cdesiniotis, elezar, shivamerla and tariq1890 as code owners November 24, 2025 18:38

shivakunv self-assigned this Nov 24, 2025

shivakunv requested review from rahulait and rajathagasthya November 28, 2025 11:45

tariq1890 reviewed Dec 2, 2025

View reviewed changes

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml Outdated Show resolved Hide resolved

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml Outdated Show resolved Hide resolved

shivakunv force-pushed the grouptagcommitwithbundle branch 3 times, most recently from a8eb42b to 6f8277b Compare December 3, 2025 05:26

rajathagasthya reviewed Dec 9, 2025

View reviewed changes

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml Show resolved Hide resolved

.github/renovate.json Show resolved Hide resolved

.github/renovate.json Outdated Show resolved Hide resolved

shivakunv commented Dec 10, 2025

View reviewed changes

rajathagasthya reviewed Dec 12, 2025

View reviewed changes

bundle/manifests/gpu-operator-certified.clusterserviceversion.yaml Outdated Show resolved Hide resolved

shivakunv force-pushed the grouptagcommitwithbundle branch from 6f8277b to f3e6ed9 Compare December 13, 2025 06:48

shivakunv force-pushed the grouptagcommitwithbundle branch 2 times, most recently from 6e19949 to c769a2d Compare January 9, 2026 10:32

shivakunv force-pushed the grouptagcommitwithbundle branch from c769a2d to eaa6081 Compare February 9, 2026 07:28

shivakunv requested a review from karthikvetrivel as a code owner February 9, 2026 07:28

rahulait reviewed Feb 10, 2026

View reviewed changes

.github/renovate.json Outdated Show resolved Hide resolved

shivakunv force-pushed the grouptagcommitwithbundle branch from eaa6081 to 2061238 Compare February 11, 2026 12:03

rahulait reviewed Feb 11, 2026

View reviewed changes

.github/renovate.json Outdated Show resolved Hide resolved

shivakunv force-pushed the grouptagcommitwithbundle branch from 2061238 to 0c22e75 Compare February 12, 2026 11:58

rahulait reviewed Feb 12, 2026

View reviewed changes

.github/renovate.json Outdated Show resolved Hide resolved

rahulait reviewed Feb 12, 2026

View reviewed changes

.github/renovate.json Outdated Show resolved Hide resolved

shivakunv force-pushed the grouptagcommitwithbundle branch from 0c22e75 to b875ade Compare February 12, 2026 16:27

rahulait reviewed Feb 12, 2026

View reviewed changes

.github/renovate.json Show resolved Hide resolved

rahulait approved these changes Feb 12, 2026

View reviewed changes

rajathagasthya force-pushed the grouptagcommitwithbundle branch 5 times, most recently from 4c50f01 to a63305b Compare February 18, 2026 22:33

shivakunv force-pushed the grouptagcommitwithbundle branch 2 times, most recently from 2587090 to f137ff6 Compare February 19, 2026 05:53

shivakunv mentioned this pull request Feb 19, 2026

Update nvcr.io/nvidia/k8s-device-plugin Docker digest to 964847c #2139

Closed

1 task

rajathagasthya approved these changes Feb 19, 2026

View reviewed changes

fix: update digest lookup to use versioned RepoTags instead of latest

2f55809

Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com> Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>

rajathagasthya force-pushed the grouptagcommitwithbundle branch from f137ff6 to 2f55809 Compare February 20, 2026 18:51

rajathagasthya requested a review from tariq1890 February 23, 2026 17:49

cdesiniotis reviewed Feb 26, 2026

View reviewed changes

Conversation

shivakunv commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivakunv commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajathagasthya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shivakunv commented Dec 20, 2025

Uh oh!

cdesiniotis commented Jan 8, 2026

Uh oh!

shivakunv commented Jan 9, 2026

Uh oh!

cdesiniotis commented Jan 10, 2026

Uh oh!

shivakunv commented Jan 10, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rahulait commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahulait left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shivakunv commented Nov 24, 2025 •

edited

Loading

shivakunv commented Nov 24, 2025 •

edited

Loading

coveralls commented Nov 24, 2025 •

edited

Loading