Use public packages to create dev/char symlinks#1819
Draft
elezar wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Use public packages to create dev/char symlinks#1819elezar wants to merge 2 commits intoNVIDIA:mainfrom
elezar wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change switches to the nvdevices and nvmodules packages from nvidia-container-toolkit to create symlinks in /dev/char instead of importing the cmd package. Signed-off-by: Evan Lezar <elezar@nvidia.com>
tariq1890
reviewed
Oct 22, 2025
| nvmodules.WithRoot(driverRootCtrPath), | ||
| ) | ||
| if err := modules.LoadAll(); err != nil { | ||
| return fmt.Errorf("failed to load NVIDIA kernel modules: %v", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed to load NVIDIA kernel modules: %v", err) | |
| return fmt.Errorf("failed to load NVIDIA kernel modules: %w", err) |
| err = creator.CreateLinks() | ||
| if err != nil { | ||
| if err := devices.CreateNVIDIAControlDevices(); err != nil { | ||
| return fmt.Errorf("failed to create device nodes for NVIDIA control devices: %v", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("failed to create device nodes for NVIDIA control devices: %v", err) | |
| return fmt.Errorf("failed to create device nodes for NVIDIA control devices: %w", err) |
Contributor
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
rahulait
removed
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change switches to the nvdevices and nvmodules packages
from nvidia-container-toolkit to create symlinks in /dev/char
instead of importing the cmd package.
This depends on #1372
See NVIDIA/mig-parted#262 for related work.