[dcgm-exporter] Add option hostNetwork for dcgmExporter#1545
Closed
Alja9 wants to merge 4 commits intoNVIDIA:mainfrom
Closed
[dcgm-exporter] Add option hostNetwork for dcgmExporter#1545Alja9 wants to merge 4 commits intoNVIDIA:mainfrom
Alja9 wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Contributor
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is it possible to add the
hostNetworkoption to thedcgm-exporterviagpu-operator?because the
dcgm-exporteritself already provides that option :https://github.com/NVIDIA/dcgm-exporter/blob/8fd69339fe2138459d3618508c3ebb1f43b51f79/deployment/templates/daemonset.yaml#L49-L50
Why is this necessary? because the label on the
dcgm-exportermetrics does not have a node label to display the node name, while the label provided by thedcgm-exporterthat is possible to display the node name is onlyhostname(can use node name or pod name).And I think this is useful for monitoring tools that require access to node-level network interfaces or need to expose ports directly on the node. And actually I want the
dcgm-exporterto use the node IP as the pod IP instead of assigning its own IP or new IP (this helps to use node ip on value instance label).And also it seems there is a request for this feature in the issue : #1086