Docker: Add custom icons for Nsight Systems and Nsight Compute launcher entries#152
Open
brycelelbach wants to merge 1 commit intomainfrom
Open
Docker: Add custom icons for Nsight Systems and Nsight Compute launcher entries#152brycelelbach wants to merge 1 commit intomainfrom
brycelelbach wants to merge 1 commit intomainfrom
Conversation
brycelelbach
changed the title
Collaborator
Author
|
I neglected to mention this is a backport from Dana. |
Collaborator
Author
|
Link check/validator broken until #151 is merged. |
brycelelbach
force-pushed
the
feature/add-icons-for-nsight-streamers
branch
2 times, most recently
from
95c8ae0 to
f16cc52
Compare
brycelelbach
force-pushed
the
feature/add-icons-for-nsight-streamers
branch
from
f16cc52 to
ac33650
Compare
Contributor
❌ Link Check FailedBroken links were detected in this PR. Please check the workflow run logs for details on which links are broken. Common fixes:
To test links locally:./brev/test-links.bash . |
… entries. Change the server proxy category to "Console" so icons render correctly in the JupyterLab launcher.
brycelelbach
force-pushed
the
feature/add-icons-for-nsight-streamers
branch
from
ac33650 to
8cb2904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brev/icons/.brev/jupyter-server-config.pyto reference the new icons viaicon_pathand change the launcher category from "Nsight" to "Console" (required for JupyterLab to render custom icons).