fix(ci): enable e2e for fork PRs via pull_request_target#680
Closed
johntmyers wants to merge 1 commit intomainfrom
Closed
fix(ci): enable e2e for fork PRs via pull_request_target#680johntmyers wants to merge 1 commit intomainfrom
johntmyers wants to merge 1 commit intomainfrom
Conversation
johntmyers
force-pushed
the
fix/e2e-skip-fork-prs
branch
from
d49c40e to
a5f94ef
Compare
pimlock
previously approved these changes
Mar 30, 2026
johntmyers
force-pushed
the
fix/e2e-skip-fork-prs
branch
from
a5f94ef to
76ae655
Compare
johntmyers
changed the title
johntmyers
force-pushed
the
fix/e2e-skip-fork-prs
branch
from
76ae655 to
8d654f9
Compare
johntmyers
changed the title
johntmyers
force-pushed
the
fix/e2e-skip-fork-prs
branch
6 times, most recently
from
e26aead to
50d7bc2
Compare
The local-build approach (single job, no GHCR push) is not feasible because the CI container cannot configure the host Docker daemon's insecure registry list, and container networking prevents access to the local registry on the host loopback. Switch to pull_request_target instead, which runs in the base repo context with write permissions to GHCR. The existing three-job pipeline (build-gateway, build-cluster, e2e) works unchanged. Security: the test:e2e label is a maintainer trust gate — only org members can apply it, signalling the PR code has been reviewed. Add ref input to docker-build.yml and e2e-test.yml so callers can pass github.event.pull_request.head.sha for checkout and image tagging, since github.sha points to the base branch under pull_request_target.
johntmyers
force-pushed
the
fix/e2e-skip-fork-prs
branch
from
50d7bc2 to
30956e1
Compare
johntmyers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable full e2e test pipeline for fork PRs by switching to
pull_request_targetand addingrefinput to reusable workflows.Related Issue
Observed on PR #672 — fork PRs can't push to GHCR due to read-only
GITHUB_TOKEN.Why not local-build?
Attempted a single-job local-build approach (build images with
--load, use local registry, no GHCR push). It failed because:--network hostconflicts with Actions' auto-created container networkhost.docker.internaldoesn't resolve in Linux CI containersChanges
branch-e2e.yml:pull_request->pull_request_target. Passesgithub.event.pull_request.head.shaas explicit ref to all child workflows. Thetest:e2elabel requirement is the security gate.docker-build.yml: Newrefinput overrides checkout ref andIMAGE_TAG. Defaults to empty (falls back togithub.sha), so existing callers (release-tag.yml,release-dev.yml) are unaffected.e2e-test.yml: Newrefinput for checkout.github.shaunderpull_request_targetUnder
pull_request_target,github.shais the base branch HEAD. Without therefoverride, the workflow would build and test main instead of the PR. The explicit ref fixes this.Checklist