Unify timestamp checks and fix headerless FPS checks

[bmchalenv]

No description provided.

[greptile-apps]

Greptile Summary

Refactored timestamp validation logic to use a unified TimeSourceState struct and generic checkTimeSource() function, reducing code duplication. The PR fixes handling of headerless messages (those with msg_timestamp_ns == 0) by skipping message timestamp checks when no header is present, preventing incorrect FPS calculations.

• Introduced TimeSourceState struct to encapsulate per-source state (node time vs message timestamp)
• Unified timestamp checking into checkTimeSource(), checkFPS(), and checkIncreasing() helper functions
• Added enable_increasing_node_time_diagnostics config option for symmetry
• Fixed headerless message handling: only checks message timestamp source when has_msg_timestamp is true
• Updated setExpectedDt() and clearExpectedDt() to synchronize both config flags and source state

Confidence Score: 4/5

• Safe to merge with one minor initialization fix needed
• The refactoring significantly improves code organization and fixes the headerless message handling bug. One missing initialization for node_source_.check_increasing should be added before merging to ensure complete symmetry between node and message time sources.
• greenwave_monitor/include/greenwave_diagnostics.hpp needs node_source_.check_increasing initialization added in constructor

Important Files Changed

Filename	Overview
greenwave_monitor/include/greenwave_diagnostics.hpp	Refactors timestamp checking logic into unified TimeSourceState struct and checkTimeSource() function. Adds support for increasing node time diagnostics. Missing initialization for node_source_.check_increasing in constructor.

_{Last reviewed commit: 44ae17d}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

node_source_.check_increasing is never initialized, but msg_source_.check_increasing is set on line 95. Add:

Suggested change

	node_source_.check_fps = diagnostics_config_.enable_node_time_diagnostics;
	node_source_.check_increasing = diagnostics_config_.enable_increasing_node_time_diagnostics;