Potential fix for code scanning alert no. 10: Workflow does not contain permissions#455
Merged
cedricfung merged 1 commit intomainfrom Mar 16, 2026
Merged
Potential fix for code scanning alert no. 10: Workflow does not contain permissions#455cedricfung merged 1 commit intomainfrom
cedricfung merged 1 commit intomainfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/MixinNetwork/bot-api-nodejs-client/security/code-scanning/10
In general, the fix is to explicitly declare
permissions:in the workflow, restricting theGITHUB_TOKENto the minimum required. If neither job needs to write to the repo or other resources viaGITHUB_TOKEN, we can safely setcontents: readat the workflow level and let it apply to both jobs.The best fix here is to add a top-level
permissions:block under the workflowname:(or underon:) so it applies to all jobs. Since the current workflow only checks out code, sets up Node, runs tests, and publishes to npm using a separate secret (NODE_AUTH_TOKEN), it does not require any write permissions on the repo; read-only access to contents is sufficient. We therefore set:This should be inserted between the
name: Node.js Packageline and theon:block (around line 5–6). No other code changes, imports, or definitions are needed, and existing functionality remains unchanged.Suggested fixes powered by Copilot Autofix. Review carefully before merging.