Clarify docs for arm64 packed unwind, RegI=0 RegF>0

[mstorsjo]

The condition CR=0 isn't correct here; the same about the first store for float registers doing the predecrement for any variant where there are no integer registers stored before the floats - this goes for both CR=0, CR=2 and CR=3.

[prmerger-automator]

@mstorsjo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

[mstorsjo]

CC @pmsjt

[learn-build-service-prod]

Learn Build status updates of commit 2008082:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/build/arm64-exception-handling.md	✅Succeeded

For more details, please refer to the build report.

[ktoliver]

@TylerMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

[pmsjt]

The replacement is accurate.

When

    fnent_pdata.RegF != 0;
    fnent_pdata.RegI == 0;

the only case where we get save_fregp instead of a save_fregp_x is when

    fnent_pdata.CR == PdataCrUnchainedSavedLr // 1

Thank you for the fix @mstorsjo .

But we might have to finesse this statement a little better. "the decrement" means which decrement? See, in both the PdataCrChainedWithPac (2) and the PdataCrChained (3) we end up with 2 pre-decrements.

For example:

    fnent_pdata.Flag = PdataPackedUnwindFunction;
    fnent_pdata.RegF = 1;
    fnent_pdata.RegI = 0;
    fnent_pdata.H = 0;
    fnent_pdata.CR = PdataCrChainedWithPac;
    fnent_pdata.FrameSize = 64 / 16;

Results in

end
pac
save_fregp_x    (d8, d9, -16)
save_fplr_x     (-48)
set_fp

So, we should clarify that this pre-decrement is just to cover for the FP/SIMD registers. This is true even for the PdataCrUnchained (0) case:

    fnent_pdata.Flag = PdataPackedUnwindFunction;
    fnent_pdata.FunctionLength = 0xB0 / 4;
    fnent_pdata.RegF = 1;
    fnent_pdata.RegI = 0;
    fnent_pdata.H = 0;
    fnent_pdata.CR = PdataCrUnchained;
    fnent_pdata.FrameSize = 64 / 16;

results in

end
save_fregp_x    (d8, d9, -16)
alloc           (48)

[learn-build-service-prod]

Learn Build status updates of commit 917032b:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
	❌Error		Details

• Line 0, Column 0: [Error: download-failed] Download failed for file 'https://opdhsblobprod03.blob.core.windows.net/contents/81a94e9e1903429e94816b2fcdc7b032/c7e6f8f047146f36d0e6411177ac6d9f'. Try closing and reopening the PR. If you get this Error again, file an issue.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

[learn-build-service-prod]

Learn Build status updates of commit 6ee1126:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/build/arm64-exception-handling.md	✅Succeeded

For more details, please refer to the build report.

[TylerMSFT]

@mstorsjo @pmsjt, I didn't see a response to the last feedback. I took a shot at it but this isn't my area. Is my update acceptable?

[learn-build-service-prod]

Learn Build status updates of commit 5dca165:

✅ Validation status: passed

File	Status	Preview URL	Details
docs/build/arm64-exception-handling.md	✅Succeeded

For more details, please refer to the build report.