Conversation
…g test.mjs script
Contributor
|
I've taken over this PR. It should be complete now, but I've requested @tegefaulkes to review it once before merging. After merging, @CDeltakai can start integration into polykey for addressing MatrixAI/Polykey#822. |
tegefaulkes
reviewed
Jun 12, 2025
Comment on lines
+18
to
+26
| name: utils.decodeFilePath(data), | ||
| type: utils.extractString(data, 156, 1), | ||
| mode: utils.extractOctal(data, 100, 8), | ||
| uid: utils.extractOctal(data, 108, 8), | ||
| gid: utils.extractOctal(data, 116, 8), | ||
| size: utils.extractOctal(data, 124, 12), | ||
| mtime: utils.extractOctal(data, 136, 12), | ||
| format: utils.extractString(data, 257, 6), | ||
| version: utils.extractString(data, 263, 2), |
There was a problem hiding this comment.
Out of scope for this PR, but there's a lot of magic numbers here.
Contributor
There was a problem hiding this comment.
I do have constants corresponding to these magic numbers. Might've slipped my mind during initial implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the repository to ESM.
Issues Fixed
js-virtualtarto ESM #3 (ENG-628)Tasks
Final checklist