Skip to content

Handle expressions not representable by SymPy #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rocky merged 2 commits into from
Feb 10, 2026
Merged

Handle expressions not representable by SymPy #254

rocky merged 2 commits into from
Feb 10, 2026
+17 −3

Conversation

@hrueter
Copy link
Contributor

@hrueter hrueter commented Mar 29, 2022

This deals with some cases where it is safe to return the expression, when it cannot be handled by SymPy.

TiagoCavalcante
TiagoCavalcante approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@TiagoCavalcante TiagoCavalcante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatera
Copy link
Contributor

mmatera commented Mar 29, 2022

@hrueter, could you some examples in which this change has an impact?

@rocky
Copy link
Member

rocky commented Mar 30, 2022

@hrueter, could you some examples in which this change has an impact?

Even better would be to add a test.

@rocky rocky force-pushed the master branch 4 times, most recently from 71081e7 to 93ed59e Compare July 27, 2022 12:37
@mmatera
Copy link
Contributor

mmatera commented Feb 1, 2026

@hreuter, is this PR still valid?

@hrueter
Copy link
Contributor Author

hrueter commented Feb 3, 2026 •
edited
Loading

@hreuter, is this PR still valid?

You got my github handle wrong. ;-)

I will check whether this is still relevant. But first some new bugs have to be fixed, so that I can run my old test problem again.

@hrueter hrueter mentioned this pull request Feb 3, 2026
Closed
@hrueter hrueter force-pushed the fix_apart branch 3 times, most recently from e078418 to f2e3df9 Compare February 9, 2026 18:08
@hrueter
Copy link
Contributor Author

hrueter commented Feb 10, 2026

I have added tests for the three functions that I am fixing here.
The test cases may seem a bit artificial, but they represent what I actually use in some WMA scripts.

@hrueter
Copy link
Contributor Author

hrueter commented Feb 10, 2026

The added documentation text is a little bit rough. If you have suggestions to describe what these tests actually prove, let me know.
WL does not really document what is supposed to happen in these cases, but this is what is observed in WMA.

@rocky
Copy link
Member

rocky commented Feb 10, 2026

The added documentation text is a little bit rough. If you have suggestions to describe what these tests actually prove, let me know. WL does not really document what is supposed to happen in these cases, but this is what is observed in WMA.

Thanks. I will try to look at later today.

@rocky
Copy link
Member

rocky commented Feb 10, 2026

LGTM - thanks.

@rocky rocky merged commit 0236a00 into Mathics3:master Feb 10, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TiagoCavalcante TiagoCavalcante TiagoCavalcante approved these changes

@rocky rocky Awaiting requested review from rocky

@mmatera mmatera Awaiting requested review from mmatera

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hrueter @mmatera @rocky @TiagoCavalcante