Fixes form error + hint when friend request sent#284
Fixes form error + hint when friend request sent#284Rgoplay wants to merge 2 commits intoMathMan05:mainfrom
Conversation
Added hint when friend request is sent
|
Reverting back overflow change because it breaks scrolling when necessary. I made error toast move the element below them which is not ideal but working. |
| background: var(--channel-hover); | ||
| border-radius: 0.1in; | ||
| position: absolute; | ||
| position: relative; |
There was a problem hiding this comment.
why is it being switched from absolute to relative?
There was a problem hiding this comment.
Because when absolute, there is no space created for the error message, and it create scrolling (as the area is too small contain the error message). So the message become "hidden" behind the scroll. When relative, a space is created so elements below are moved but it doesn't create a scrollable area.
There was a problem hiding this comment.
won't that make layout shifts then?
There was a problem hiding this comment.
Yes unfortunately, but I think that's better than just not seeing the error.
I don't really know how to make it better
2 participants
Description
Changed the overflow of form to be visible so that when an error toast is created it is shown and not hidden below with a scrollbar because of overflowing. Might not be the best solution as if the form goes outside the screen there is no scrolling.
Added a placeholder text when the friend request is sent.
Related issues
Issue #240