Merged
Conversation
This was referenced Feb 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2838 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 134 134
Lines 7410 7410
Branches 1650 1555 -95
=======================================
Hits 5341 5341
Misses 1941 1941
Partials 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Looks good, but need you to update the dev docs! (Step 6 of https://markbind.org/devdocs/devGuide/development/migratingNodeJs.html) |
Contributor
Author
|
Alright the docs list the node version as 22. Is there any part I missed? |
gerteck
approved these changes
Feb 20, 2026
Member
Nope, I don't think so. looks good 👍 |
Member
|
Devdocs now show Node v22 or higher 🎉 https://markbind.org/devdocs/devGuide/development/settingUp.html#prerequisites |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Anything you'd like to highlight/discuss:
markbind deployworks as expected (see test deployment here) (NOTE: this was done after applying the patch in Fixmarkbind serveregression #2837 manually since it wasn't merged yet)Related PRs:
Update markbind-action to node v22
Update init-typical-netlify configs to node v22
Update init-minimal-netlify configs to node v22
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Migrate MarkBind to Node.js v22
MarkBind uses node18.
Node18's last update was Mar 2025, and
is now EOL.
Change node version to 22 (LTS).
Skip version 20 as v20 is EOL in 2 months.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):