-
Notifications
You must be signed in to change notification settings - Fork 142
Migrate packages/vue-components Utils files to TS #2834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gerteck
merged 23 commits into
MarkBind:master
from
yihao03:feat/migrate-vue-utils-to-ts
Feb 21, 2026
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
519f6ae
Rename vue-components/src/utils/pubsub to TypeScript
yihao03 4e7990f
Adapt vue-components/src/utils/pubsub to TypeScript
yihao03 7d5345b
Rename vue-components/src/utils/urls to TypeScript
yihao03 50bc202
Adapt vue-components/src/utils/urls to TypeScript
yihao03 582ab95
Rename vue-components/src/utils/dropdown to TypeScript
yihao03 b2b7327
Adapt vue-components/src/utils/dropdown to TypeScript
yihao03 651341a
Rename vue-components/src/utils/submenu to TypeScript
yihao03 edc2b25
Adapt vue-components/src/utils/submenu to TypeScript
yihao03 f854481
Rename vue-components/src/utils/colors to TypeScript
yihao03 87cb766
Adapt vue-components/src/utils/colors to TypeScript
yihao03 af23ecc
Rename vue-components/src/utils/utils to TypeScript
yihao03 1a86eff
Adapt vue-components/src/utils/utils to TypeScript
yihao03 f4785a8
Rename vue-components/src/utils/NodeList to TypeScript
yihao03 d5ce791
Adapt vue-components/src/utils/NodeList to TypeScript
yihao03 7f5f434
Add TypeScript infrastructure for vue-components package
yihao03 71a5060
Refactor getJSON to use native Promise
yihao03 822c4fe
Add tsconfig.json and typecheck script for vue-components
yihao03 e927eec
Update eslint config
yihao03 9c28289
Add babel preset-typescript to root level config
yihao03 2cd242b
Replace coerce object with toBoolean
yihao03 f84db8a
Remove redundant ignores
yihao03 0e033be
Add typecheck to test script
yihao03 b9e028b
Merge branch 'master' into feat/migrate-vue-utils-to-ts
gerteck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module.exports = { | ||
| presets: ['@babel/preset-env'], | ||
| presets: ['@babel/preset-env', '@babel/preset-typescript'], | ||
| plugins: ['@babel/plugin-transform-runtime'], | ||
| }; |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| module.exports = { | ||
| presets: ['@babel/preset-env'], | ||
| presets: [ | ||
| '@babel/preset-env', | ||
| '@babel/preset-typescript', | ||
| ], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test script now runs
tscfor type-checking before every test run. This adds overhead and differs from the typical pattern where type-checking is a separate step. Consider whether type-checking should be part of the test script or kept separate asnpm run typecheck. If tests should validate types, the current approach is correct. If type-checking should be independent, the test script could remain asjest --clearCache && jest --colorsand rely on CI or pre-commit hooks to run type-checking separately.