MDEV-38855 Remove obsolete compiler version checks from storage/rocksdb/CMakeLists.txt

[ChandanaRamakrishna]

Part 1 of MDEV-35462, removing obsolete compiler version checks.

Changes

Simplified storage/rocksdb/CMakeLists.txt by removing:

• GCC < 4.8 and < 5.0 version checks
• Clang < 3.3 version checks
• CMake < 3.0 fallback logic
• Manual -std=c++11 flag handling

Replaced with modern CMAKE_CXX_STANDARD configuration.

Confirmed Minimums

As confirmed by @marko:

• GCC >= 7
• Clang >= 10
• CMake >= 3.12

Use CMAKE_CXX_STANDARD for C++11 configuration.

Related

• JIRA: https://jira.mariadb.org/browse/MDEV-35462
• Discussion: https://mariadb.zulipchat.com/#narrow/channel/118760-New-Members/topic/MDEV-35462.20-.20Compiler.20Cleanup

No functional changes intended.

[CLAassistant]

All committers have signed the CLA.

[gkodinov]

Since this is not the full MDEV-35462 I've created a sub-task of it and added the contribution to it.

[gkodinov]

Thank you for your contribution. LGTM. Note that this is a preliminary review. Please wait for the final reviewer assignment.

[ChandanaRamakrishna]

Removed the MSVC_VERSION check as suggested. Leaving the clang-cl check pending your review.

…

On Wed, 18 Feb 2026 at 15:39, Vladislav Vaintroub ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In storage/rocksdb/CMakeLists.txt <#4663 (comment)>: > + if (MSVC_VERSION LESS 1900) SKIP_ROCKSDB_PLUGIN("${OLD_COMPILER_MSG}") So please, proceed remove MSVC version check. But about clang-cl I do not know, I'll check. — Reply to this email directly, view it on GitHub <#4663 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3O75UCHU5CQTIJYUNEWD734MQ26FAVCNFSM6AAAAACVNNQQJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMJYHE2TOMRZGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ChandanaRamakrishna]

Removed unnecessary -fPIC for MSVC and adjusted the clang-cl handling as suggested. Please take another look.

…

On Wed, 18 Feb 2026 at 16:58, Vladislav Vaintroub ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In storage/rocksdb/CMakeLists.txt <#4663 (comment)>: > + if (MSVC_VERSION LESS 1900) SKIP_ROCKSDB_PLUGIN("${OLD_COMPILER_MSG}") clang-cl compiles, but complains about unnecessary -fPIC, added for whatever purpose here https://github.com/MariaDB/server/blob/main/storage/rocksdb/build_rocksdb.cmake#L548 So, maybe you can remove both the unnecessary -fPIC and the clang-cl check as well? — Reply to this email directly, view it on GitHub <#4663 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3O75UHN35NUROFYH65JQID4MREHNAVCNFSM6AAAAACVNNQQJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMJZGMZTENBVGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[vaintroub]

Just remove that -fPIC always from the above line. Always, not just for clang-cl. For everything. no need for more IF. No need for more -fPICs . ADD_CONVENIENCE_LIBRARY above adds that if needed.

[vaintroub]

I'm ok with that.
I would not split lines in SET_TARGET_PROPERTIES in build_rocksdb.cmake, those are not too long, but no strong opinions . It is probably VSCode that formats that for you?

[ChandanaRamakrishna]

Thanks for pointing that out. Yes, that was VSCode formatting — I’ve restored it to a single line.

…

On Wed, 18 Feb 2026 at 19:16, Vladislav Vaintroub ***@***.***> wrote: ***@***.**** approved this pull request. I'm ok with that. I would not split lines in SET_TARGET_PROPERTIES in build_rocksdb.cmake, those are not too long, but no strong opinions . It is probably VSCode that formats that for you? — Reply to this email directly, view it on GitHub <#4663 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A3O75UHVV3ZECT7D6MXRJJL4MRUK3AVCNFSM6AAAAACVNNQQJWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMRQGAYDENRSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>