MDEV-38583 : Fix TO_DATE Urdu parsing mismatch with Oracle#4649
Open
Mahmoud-kh1 wants to merge 1 commit intoMariaDB:mainfrom
Open
MDEV-38583 : Fix TO_DATE Urdu parsing mismatch with Oracle#4649Mahmoud-kh1 wants to merge 1 commit intoMariaDB:mainfrom
Mahmoud-kh1 wants to merge 1 commit intoMariaDB:mainfrom
Conversation
Mahmoud-kh1
force-pushed
the
fix-urdu-parsing
branch
from
9c29faa to
d649859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fix the problem with parsing urdu dates.
previously, TO_DATE() would return NULL when using Urdu month or day names
I found the issue in the matching logic. I suspected some characters were written incorrectly and since these differences are not always visible to the eye I verified it using hex based testing.
Each character is encoded as four hex digits if we compare the values will see difference in the character before the last one, even they look identical , one of two words has this character as URDU and one as Arabic one.
I have fixed the harded coded words by replacing all with standard urdu and shows the hexa to ensure it's correct
Now it works as intended
also I have added test to verify this change
issue:
MDEV-38583