Reduce PV forecast failsafe minimum from 18 to 12 hours

[Copilot]

• Reduce minimum forecast hours from 18 to 12 in baseclass.py
• Fix off-by-one: use len(current_aligned_forecast) instead of max(keys()) for interval count check
• Update error log to report actual interval count
• Update tests in test_baseclass.py and test_baseclass_alignment.py
• All 275 tests pass
• CodeQL: 0 alerts

Original prompt

---

This section details on the original issue you should resolve

<issue_title>To agressive failsafe for PV values</issue_title>
<issue_description>In the time window between 0.00 and 02.00 o'clock , it seems that the values for production are not correctly delivered, or are not until the end of the day.
And the amount of "hours" may be wrong. If interval_minutes = 60 , 18 slots are ok. For 15 minutes it needs to be 18 * 4 = 60 slots.

I think to reduce the value down to 12 hours , 48 slots a 15 minutes.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes To agressive failsafe for PV values #283

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

Adjusts the solar forecast failsafe to accept shorter PV forecasts during early-night hours by reducing the minimum required forecast horizon from 18 hours to 12 hours, and updates tests accordingly.

Changes:

• Lowered the minimum forecast-length threshold in the ForecastSolar baseclass from 18h to 12h (including 15-min equivalent).
• Updated RuntimeError message text to reference 12 hours.
• Updated unit tests to match the new threshold and adjust insufficient-data fixtures.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/batcontrol/forecastsolar/baseclass.py	Lowers the minimum forecast horizon check to 12 hours and updates the emitted error/log messages.
tests/batcontrol/forecastsolar/test_baseclass.py	Updates failing test matcher to expect the new 12-hour error message.
tests/batcontrol/forecastsolar/test_baseclass_alignment.py	Updates integration tests/matchers and insufficient 15-min test data to reflect the new 12-hour threshold.

[MaStr]

@copilot apply changes based on the comments in this thread

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• test.example.com
  • Triggering command: /usr/bin/python python -m pytest tests/ -q (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)