Open
Conversation
Because FStart sometimes equaled the buffer size, a Range Check Error could occur. Fixed.
Owner
|
Thanks for providing this fix. But before I can accept it we need to check two things:
It would be really nice if you could do these. I also don't know why you have such issues with our lovely German umlauts. Maybe the files are still ANSI. If yes, I'll change them to UTF8 after accepting your pull request. |
Author
|
Hi, The umlaut thing happened because I edited the file directly in the GithHub web site. I think it converted it to UTF-8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because FStart sometimes equaled the buffer size, a Range Check Error could occur. Fixed.
There are two places in the source where I needed to add:
if FStart=Size then
FStart:=0;
Unfortunately the pull request contains some additional "changes" due to German umlauts, sorry for that!