feat: standardized stream pages by ElectricalBoy · Pull Request #7113 · Liquipedia/Lua-Modules

ElectricalBoy · 2026-02-19T07:35:09Z

Summary

Resolves #6652

How did you test this change?

https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox4
https://liquipedia.net/counterstrike/User:ElectricalBoy/Sandbox (only for testing StreamPage/Team, custom is oos for now)
https://liquipedia.net/starcraft2/User:ElectricalBoy/Sandbox

hjpalpha · 2026-02-19T08:58:44Z

regarding sc2:

imo we should (re-) add the team in the player infos
the map pool table should be adjusted to use the new styles too ;)
the form stuff was removed compared to before (not opposed, just mentioning it)
the entire h2h and tournament results tabs are gone (fwiw once we have standardized standings we likely can do the tournament results tab way nicer, i.e. show the standings table instead of the matchlist for group stages ...)
- fwiw the old h2h was easier to view on phone compared to the matchhistory stuff you now display
imo it was a nice feature to have the bestof and the icon with event name shown in the overview box
the overview box looks bad on smaller widths

hjpalpha

for the sc2 file:
https://liquipedia.net/commons/index.php?title=Module%3AStreamPage%2FStarcraft%2Fdev%2FElectricalBoy&diff=968462&oldid=968448

lua/wikis/commons/StreamPage/Starcraft.lua

lua/wikis/commons/StreamPage/Base.lua

hjpalpha

imo using dynamic tabs to shorten the page/scrolling might be something to consider
and we should try to fetch the current matchgroup too (and once we have standardized standings and can build standings from lpdb stabdings data also display the group if there is one attached)

lua/wikis/commons/StreamPage/Starcraft.lua

lua/wikis/commons/StreamPage/Faction.lua

hjpalpha · 2026-02-20T05:29:32Z

some more fixes: https://liquipedia.net/commons/index.php?title=Module%3AStreamPage%2FStarcraft%2Fdev%2FElectricalBoy&diff=968655&oldid=968651

lua/wikis/commons/StreamPage/Starcraft.lua

lua/wikis/commons/StreamPage/Faction.lua

hjpalpha · 2026-02-20T06:04:41Z

don't have a good solution, but it seems weird for clem to show him as protoss in the recent stuff while he only plays protoss because he hates tvt matches

not sure if worth considering though

ElectricalBoy · 2026-02-20T06:09:46Z

don't have a good solution, but it seems weird for clem to show him as protoss in the recent stuff while he only plays protoss because he hates tvt matches

not sure if worth considering though

right now it is using whatever is available at match opponent level
disabling showFaction universally could be an option

hjpalpha · 2026-02-20T08:05:17Z

fwiw the "This team has not played any matches yet." seems suboptimal in cases where opponents have no h2h

https://liquipedia.net/counterstrike/User:ElectricalBoy/Sandbox

maybe we should make that something like "Liquipedia has no recorded Head to Head for these opponents"
(would mean making the text in the recent matches table adjustable)

hjpalpha · 2026-02-20T09:31:37Z

don't have a good solution, but it seems weird for clem to show him as protoss in the recent stuff while he only plays protoss because he hates tvt matches
not sure if worth considering though

right now it is using whatever is available at match opponent level disabling showFaction universally could be an option

i think we will just leave that as is^^

hjpalpha · 2026-02-20T09:32:26Z

fyi, the /Team version in dev doesn't match what is in the PR (the stuff in the PR throws currently on cs due to a missing nil check)

hjpalpha · 2026-02-20T09:36:47Z

i was playing around a bit with this:

https://liquipedia.net/starcraft2/User:Hjpalpha/wip17

among other things i was trying to push the bottom content (h2h) into a tab too
works nicely on desktop and tablet and horizontal mode phone
on vertical mode phone the overflow for the match tables breaks so that one can not scroll these tables to the right

(had to jump into meetings when writing this)

ElectricalBoy · 2026-02-20T10:09:13Z

on vertical mode phone the overflow for the match tables breaks so that one can not scroll these tables to the right

#7123

ElectricalBoy · 2026-02-24T06:30:29Z

fwiw the "This team has not played any matches yet." seems suboptimal in cases where opponents have no h2h
https://liquipedia.net/counterstrike/User:ElectricalBoy/Sandbox

maybe we should make that something like "Liquipedia has no recorded Head to Head for these opponents" (would mean making the text in the recent matches table adjustable)

#7142

lua/wikis/commons/StreamPage/Team.lua

hjpalpha · 2026-02-24T09:32:44Z

fwiw the "This team has not played any matches yet." seems suboptimal in cases where opponents have no h2h
https://liquipedia.net/counterstrike/User:ElectricalBoy/Sandbox
maybe we should make that something like "Liquipedia has no recorded Head to Head for these opponents" (would mean making the text in the recent matches table adjustable)

#7142

fwiw i personally think it would be nice to show it, but imo not a blocker

Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>

hjpalpha · 2026-03-30T01:32:34Z

needs rebase

hjpalpha

modules:sync remove suppressBottomContent option and adjust otherwise

overwrite bototm content with returning nil and do custombottomcontent

--> would break the tabs stuff
possibly making it always use tabs if there is no matchpage usage?!?

hjpalpha · 2026-04-02T16:01:25Z

@ElectricalBoy would you be opposed to always using tabs (like on sc2) if there is no matchpage setup?
(salt thinks it is a good idea too)

ElectricalBoy · 2026-04-02T16:10:31Z

would you be opposed to always using tabs (like on sc2) if there is no matchpage setup?

I don't mind

* rework * redirect to correct module * make match available * not needed anymore * this neither * aoe will use /Faction too :)

lua/wikis/commons/StreamPage/Base.lua

mbergen · 2026-04-04T11:46:43Z

lua/wikis/commons/StreamPage/Base.lua

+		if Array.any(match.opponents, Opponent.isBye) then
+			return


Why would there be matches with BYEs that have streams set, exact dates, and aren't finished 🤔

if an opponent drops out and the other opponent isn't determined yet and someone forgot to remove the date or it is auto inherited

If it is inherited, it is not set to be exact, right?

imo okay to kick

mbergen · 2026-04-04T11:52:49Z

lua/wikis/commons/StreamPage/Base.lua

+			MatchPage(self.matches[1]):render(),
+			HtmlWidgets.H3{children = 'Channel Schedule'},
+			self:_createMatchTicker():query():create()


Would it make sense to also use the grid here? the Full-width matchticker looks a bit weird.
Otherwise could use the entity variant of the ticker.

since this is the variant that gets used if there is a match page i would say electrical boy is better suited to state the opinion of wikis that use such

Co-authored-by: SyntacticSalt <mail@mbergen.de>

lua/wikis/commons/StreamPage/Base.lua

Co-authored-by: SyntacticSalt <mail@mbergen.de>

ElectricalBoy added g: starcraft Starcraft g: leagueoflegends League of Legends labels Feb 19, 2026

ElectricalBoy mentioned this pull request Feb 19, 2026

fix(match2): broken alignment for party opponents in matchpage header #7117

Merged

hjpalpha reviewed Feb 19, 2026

View reviewed changes

lua/wikis/commons/StreamPage/Base.lua Show resolved Hide resolved

ElectricalBoy force-pushed the streampage branch from 9818e0b to 9e8921b Compare February 19, 2026 09:48

hjpalpha reviewed Feb 20, 2026

View reviewed changes

lua/wikis/commons/StreamPage/Starcraft.lua Outdated Show resolved Hide resolved

lua/wikis/commons/StreamPage/Starcraft.lua Outdated Show resolved Hide resolved

lua/wikis/commons/StreamPage/Faction.lua Outdated Show resolved Hide resolved

hjpalpha reviewed Feb 20, 2026

View reviewed changes

lua/wikis/commons/StreamPage/Starcraft.lua Outdated Show resolved Hide resolved

hjpalpha reviewed Feb 20, 2026

View reviewed changes

lua/wikis/commons/StreamPage/Faction.lua Show resolved Hide resolved

ElectricalBoy mentioned this pull request Feb 20, 2026

fix(tabs): width undefined in dynamic tab content container #7123

Merged

ElectricalBoy added 11 commits February 24, 2026 14:55

add skeleton impl

f9af617

add recent matches

9a7e5e5

cleanup

e1d8eb3

move

8b714f1

css

9a75277

type annotation

d96273b

add team version

8b75999

remove unused imports

55cd42c

annotations

aa7f61e

basic starcraft impl

7cd1c26

copy from live

c657f40

hjpalpha approved these changes Feb 24, 2026

View reviewed changes

lua/wikis/commons/StreamPage/Team.lua Outdated Show resolved Hide resolved

lua/wikis/commons/StreamPage/Team.lua Outdated Show resolved Hide resolved

code conciseness

58c2176

Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>

ElectricalBoy marked this pull request as ready for review February 24, 2026 09:49

ElectricalBoy requested review from a team as code owners February 24, 2026 09:49

remove unused import

32e6313

hjpalpha approved these changes Feb 24, 2026

View reviewed changes

Merge branch 'main' into streampage

082b280

hjpalpha reviewed Apr 2, 2026

View reviewed changes

hjpalpha and others added 4 commits April 2, 2026 18:02

nil catch

5f3ee31

adjust annos to current reality :P

8094bb9

chore: update visual snapshots

24ca92a

Merge branch 'main' into streampage

f1ea137

hjpalpha added 4 commits April 2, 2026 18:22

some adjusts to the faction stuff

ef5755c

catch another nil

698e733

from discussion with salt

bc221fc

adjust maps stuff a bit

f49636e

hjpalpha mentioned this pull request Apr 2, 2026

suggestions for #7113 #7342

Merged

suggestions for #7113 (#7342)

2610f40

* rework * redirect to correct module * make match available * not needed anymore * this neither * aoe will use /Faction too :)

hjpalpha requested a review from mbergen April 3, 2026 15:54

mbergen reviewed Apr 4, 2026

View reviewed changes

Update lua/wikis/commons/StreamPage/Base.lua

2517cb7

Co-authored-by: SyntacticSalt <mail@mbergen.de>

mbergen reviewed Apr 4, 2026

View reviewed changes

lua/wikis/commons/StreamPage/Base.lua Outdated Show resolved Hide resolved

lua/wikis/commons/StreamPage/Base.lua Outdated Show resolved Hide resolved

hjpalpha and others added 2 commits April 4, 2026 17:02

Update lua/wikis/commons/StreamPage/Base.lua

70a5d8b

Co-authored-by: SyntacticSalt <mail@mbergen.de>

Update lua/wikis/commons/StreamPage/Base.lua

f3d6bfc

Co-authored-by: SyntacticSalt <mail@mbergen.de>

Conversation

ElectricalBoy commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How did you test this change?

Uh oh!

hjpalpha commented Feb 19, 2026

Uh oh!

hjpalpha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjpalpha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjpalpha commented Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

hjpalpha commented Feb 20, 2026

Uh oh!

ElectricalBoy commented Feb 20, 2026

Uh oh!

hjpalpha commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hjpalpha commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hjpalpha commented Feb 20, 2026

Uh oh!

hjpalpha commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ElectricalBoy commented Feb 20, 2026

Uh oh!

ElectricalBoy commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

hjpalpha commented Feb 24, 2026

Uh oh!

hjpalpha commented Mar 30, 2026

Uh oh!

hjpalpha left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hjpalpha commented Apr 2, 2026

Uh oh!

ElectricalBoy commented Apr 2, 2026

Uh oh!

Uh oh!

mbergen Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

hjpalpha Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mbergen Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

hjpalpha Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mbergen Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

hjpalpha Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ElectricalBoy commented Feb 19, 2026 •

edited

Loading

hjpalpha commented Feb 20, 2026 •

edited

Loading

hjpalpha commented Feb 20, 2026 •

edited

Loading

hjpalpha commented Feb 20, 2026 •

edited

Loading

hjpalpha left a comment •

edited

Loading