chore: diff, relax-ata review#2368
Draft
SwenSchaeferjohann wants to merge 14 commits intojorrit/chore-relax-ata-decompressfrom
Draft
chore: diff, relax-ata review#2368SwenSchaeferjohann wants to merge 14 commits intojorrit/chore-relax-ata-decompressfrom
SwenSchaeferjohann wants to merge 14 commits intojorrit/chore-relax-ata-decompressfrom
Conversation
The is_ata_decompress detection was too broad -- it triggered for any tx containing a Decompress compression and any CompressedOnly TLV with is_ata=true. This broke multi-account decompress batches (e.g., AMM stress test) that contain a mix of ATA and non-ATA accounts. Fix: require exactly 1 input and 1 compression as part of the detection condition, not as a separate validation that errors. Multi-input decompress txs now skip the idempotency path entirely.
…o longer requires owner signature
… and d10_token_accounts_test
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a9ddf3b to
9637da2
Compare
ddf8d0e to
f020d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.