Add a button that saves detected cart info to file#109
Open
selenologist wants to merge 1 commit intoLesserkuma:masterfrom
Open
Add a button that saves detected cart info to file#109selenologist wants to merge 1 commit intoLesserkuma:masterfrom
selenologist wants to merge 1 commit intoLesserkuma:masterfrom
Conversation
Author
|
re CRLF line endings https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files
So they should be CRLF when FlashGBX is run on Windows. Cool. Would be great if someone could test it though. |
1cba4e7 to
55b8226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I kept having to open a text editor to save the cart info copied to clipboard, so I just whipped up a save to file button.
Let me know if it needs any improvement. The error checking on the actual file saving part seems to work but it's a little hamfisted.
Haven't tested on any platforms other than Linux but we should be good, there's no directory characters in the path editing in this commit. I'm not sure whether the emitted file has Windows-friendly CRLF newlines, though.