Open
Conversation
…pe-aliases in :core, saving 400KB of jar size
…pe-aliases in :dataframe-csv
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/DocumentationUrls.kt
# Conflicts: # build.gradle.kts # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/distinct.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/groupBy.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/rename.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/AccessApi.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/DocumentationUrls.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/ExtensionPropertiesAPI.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/SelectingColumns.kt # dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentationCsv/DelimParams.kt # gradle/libs.versions.toml
# Conflicts: # build.gradle.kts # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/distinct.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/groupBy.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/rename.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/AccessApi.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/DocumentationUrls.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/ExtensionPropertiesAPI.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/SelectingColumns.kt # dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentationCsv/DelimParams.kt # gradle/libs.versions.toml
…-kdoc-helpers # Conflicts: # build.gradle.kts # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/distinct.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/groupBy.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/pivot.kt # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/rename.kt # dataframe-csv/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentationCsv/DelimParams.kt # gradle/libs.versions.toml
Collaborator
Author
|
Currently blocked by KoDeX issue: Jolanrensen/KoDEx#97. |
Collaborator
Author
|
Draft
Jolanrensen
requested changes
Mar 3, 2026
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/AccessAPIs.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/AccessApis.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/AccessAPIs.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/ColumnExpression.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/DocumentationUrls.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/generateCode.kt
Outdated
Show resolved
Hide resolved
| * If both [DataFrame]s contain columns with the same name that are *not* part of the join keys, | ||
| * such columns are treated as distinct. Such a column from the right [DataFrame] will be | ||
| * [automatically renamed][org.jetbrains.kotlinx.dataframe.documentation.AutoRenaming] | ||
| * [automatically renamed][`Auto-renaming columns in DataFrame`] |
Collaborator
There was a problem hiding this comment.
backticks in name of reference; cannot be expanded to FQ name if JoinBehavior is included elsewhere
Collaborator
There was a problem hiding this comment.
it just happens to work okay in this file, because JoinBehavior is only included within this file and `Auto-renaming columns in DataFrame` is already imported. But still, it's probably best to avoid backticks until KoDEx actually supports them
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/Nulls.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/remove.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/update.kt
Outdated
Show resolved
Hide resolved
Jolanrensen
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1688.
Closes #1654.