-
Notifications
You must be signed in to change notification settings - Fork 60
[#337] Add metadata across apps #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis PR adds Next.js page metadata exports to multiple pages across Blade, Club, and Guild applications. Most pages receive static metadata with title and description fields. One dynamic form page uses an async Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
alexanderpaolini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need nor want SEO or metadata on admin/judge pages. Best to leave that out.
Im curious how it looks in embeds when it's just ${form.title}. I feel like we might want to do Blade | ${form.title} for consistency. If you could include pictures of embeds of either type (or another I missed), I'd appreciate that a lot. There are sites online that'll let you preview metadata -- I think they're good enough for this purpose.
Overall solid; The Open Graph is big 🔥 I'm dying laughing at that typo you fixed
Why
A lot of routes were missing metadata or were using the same metadata banner
What
Issue(s): #337
Added mostly metadata titles and description through repo (mainly blade)
Added images for metadata banners as well if missing
Test Plan
Visited every page to ensure correct title was displayed
Ran format, lint, typecheck, build
Checklist
db:pushbefore mergingSummary by CodeRabbit
Release Notes
New Features
Bug Fixes