-
Notifications
You must be signed in to change notification settings - Fork 60
[#351] Filter recurring OPS and PL lab events from next week reminders #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe reminder cron job's event filtering logic is updated to use a case-insensitive predicate that excludes events tagged Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reduces Discord “Next Week” reminder noise by excluding certain recurring OPS and Project Launch lab/hour events from the “Next Week” reminder group generated by the cron reminder job.
Changes:
- Updated “Next Week” event filtering to exclude events with the
OPStag. - Updated “Next Week” event filtering to exclude
Project Launchevents whose titles include “lab” or “hours”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/cron/src/crons/reminder.ts
Outdated
| // Filter out "Operations Meeting" from nextWeek | ||
| const nextWeekFiltered = nextWeekEvents.filter( | ||
| (event) => | ||
| !event.tag.includes("Operations Meeting") && | ||
| !event.name.includes("Lab Hours"), | ||
| ); | ||
| const nextWeekFiltered = nextWeekEvents.filter((event) => { | ||
| const tag = event.tag.toLowerCase(); | ||
| const name = event.name.toLowerCase(); | ||
| const ops = tag === "ops"; | ||
| const plLab = |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline comment says this filters out "Operations Meeting", but the logic now filters OPS-tagged events and Project Launch events whose names include "lab" or "hours". Update the comment to match the current filtering criteria to avoid future confusion when adjusting reminder rules.
DVidal1205
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm gj :)
Why
Recurring OPS and PL lab events don't need next week reminders since they are weekly events. This created unnecessary noise in the discord reminders.
What
Issue(s): #351
Test Plan
Checklist
db:pushbefore mergingSummary by CodeRabbit