Open
Conversation
Collaborator
Author
|
Depends on Kitware/vtk-js#2839 |
Collaborator
Author
Contributor
|
Overall LGTM. Still haven't tested it. Will port over to beta when this is merged. |
Contributor
|
I see 2839 has been merged. Once this PR has been updated, I will test it out. |
Collaborator
Author
|
Do I need to modify the minimum vtk-js version or will the latest be automatically pulled? The new release puts vtk-js at v28.2.1 |
Contributor
|
The package-lock.json will need to be updated with an Also, I just realized this is a breaking change, since we are requiring a new major version of vtk.js as a dependency. In that case, I'll rewrite this with your input onto the beta branch. Once that's done, we can close this instead of merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the vtk-js vtkImageResliceMapper as a representation in react-vtk-js