Merged
Conversation
Add Discord as a new platform integration following the same architecture as the existing Slack integration. This includes the OAuth2 flow for adding the bot to a Discord server, storing guild information in the shared platform_integrations table, and full frontend UI for both personal and organization-level integrations. Bot implementation will follow in a subsequent PR.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (18 files)
|
RSO
changed the title
RSO
force-pushed
the
feat/discord-integration
branch
from
d907a68 to
0b8e8ed
Compare
RSO
changed the title
Contributor
|
Unblocking, please at least verify the OAuth comments and the authentication. |
marius-kilocode
approved these changes
Feb 25, 2026
The state parameter was a plain, guessable string (user_id/org_id), allowing authorization code injection attacks. Sign it with HMAC-SHA256 using NEXTAUTH_SECRET and embed the initiating user's ID so the callback can verify the flow wasn't tampered with.
The signed OAuth state payload previously only contained { owner, uid },
making it deterministic and valid indefinitely. A leaked state token
(via logs, referrer headers, browser history) could be replayed at any
time by the same authenticated user context.
Add an issued-at timestamp (iat) with a 10-minute TTL and a 128-bit
random nonce to each state token. Verification now rejects tokens that
are expired, have future timestamps, or lack the new fields.
| // 1. Verify user authentication | ||
| const { user, authFailedResponse } = await getUserFromAuth({ adminOnly: false }); | ||
| if (authFailedResponse) { | ||
| return NextResponse.redirect(new URL('/users/sign_in', APP_URL)); |
Contributor
There was a problem hiding this comment.
WARNING: Auth redirect drops OAuth callback context, causing non-recoverable install failures for signed-out users.
When getUserFromAuth fails, this redirects to /users/sign_in without preserving the current callback URL (code/state). If a user’s session expires between initiating OAuth and callback, they authenticate successfully but cannot resume the install because the authorization code/state are lost. Consider redirecting to sign-in with a callbackPath back to this callback URL so the flow can continue safely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the basic scaffolding for adding a Discord OAuth integration to the User/Organization level. It mostly works the same as our Slack integration and is heavily based on it.
CleanShot.2026-02-25.at.14.33.13.mp4