fix: use CLI session ID and correct URL in Cloud Agent feedback Slack notification#530
Open
kiloconnect[bot] wants to merge 1 commit intomainfrom
Open
fix: use CLI session ID and correct URL in Cloud Agent feedback Slack notification#530kiloconnect[bot] wants to merge 1 commit intomainfrom
kiloconnect[bot] wants to merge 1 commit intomainfrom
Conversation
… notification
The Slack notification for Cloud Agent feedback was linking to
/admin/cloud-agent/{sessionId} which results in a 404. Updated to:
- Accept cli_session_id in the feedback input schema
- Pass the CLI session ID (from currentDbSessionIdAtom) from FeedbackDialog
- Link to /admin/session-traces?sessionId={cliSessionId} in the Slack message
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "New Cloud Agent feedback" Slack notification included a session link pointing to
/admin/cloud-agent/{sessionId}, which results in a 404.Solution
cli_session_idto the Cloud Agent feedback input schema (optional field, used only for the Slack notification)FeedbackDialogto pass the CLI session ID (fromcurrentDbSessionIdAtom) alongside the existing cloud agent session ID/admin/session-traces?sessionId={cliSessionId}, which is the correct admin page for viewing session tracesChanges
src/routers/cloud-agent-next-feedback-router.ts: Addedcli_session_idto input schema; updated Slack notification link URLsrc/components/cloud-agent-next/FeedbackDialog.tsx: ImportcurrentDbSessionIdAtomand pass CLI session ID in mutationBuilt for Evgeny Shurakov by Kilo for Slack