Conversation
This PR introduces a newly made up `runSessionToCompletion` helper that mimicks the behavior from the pre-websocket interface of Cloud Agents. In the long run I'd like to move to the callbackUrl flow to prevent timeouts, but that seemed like a bigger change, and I wished to get this in quickly. I've tested locally to confirm that the `View Session` button still works and that Cloud Agents are spawned as expected.
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No New Issues Found | Recommendation: Address existing comments before merge OverviewThis PR migrates the Slack bot from the old
Existing inline comments from prior reviewers cover the notable issues (multiple Files Reviewed (4 files)
|
| onMessageCompleted: (_sid, _mid, message) => { | ||
| if (message.info.role !== 'assistant') return; | ||
| const text = extractTextFromMessage(message); | ||
| if (text) completionResult = text; |
There was a problem hiding this comment.
I don't get this logic. Will this work with partial results etc?
There was a problem hiding this comment.
I'm not 100% sure, but I assumed that onMessageCompleted is only called when the message is finalized, and that this line makes sure that we store the last message as the completion result.
Reverts #500 The Cloud Agent can currently not run on the `kilocode` repository, so I'm reverting this PR until we've fixed that.
3 participants
This PR introduces a newly made up
runSessionToCompletionhelper that mimicks the behavior from the pre-websocket interface of Cloud Agents.In the long run I'd like to move to the callbackUrl flow to prevent timeouts, but that seemed like a bigger change, and I wished to get this in quickly.
I've tested locally to confirm that the
View Sessionbutton still works and that Cloud Agents are spawned as expected.