Remove redundant OpCode in UNTIL loop#3164
Open
DBooots wants to merge 2 commits intoKSP-KOS:developfrom
Open
Conversation
Added error handling for type conversion in branch instructions to align with the not opcode. See KSP-KOS#3094
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3094
Added try-catch block to OpcodeBranchIfTrue and OpcodeBranchIfFalse to capture the protection that was presumably the root cause of the not -> branchIfFalse logic. Then removed the redundant Not opcode in favor of the equivalent logic using OpcodeBranchIfTrue.