feat(style): Revamp the entire UI to have less borders and distractions#87
Merged
feat(style): Revamp the entire UI to have less borders and distractions#87
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f38b8ee to
4c89c3d
Compare
Contributor
Greptile SummaryThis PR replaces full-bordered rounded blocks with minimal single-edge borders across all UI components, adds line-number gutters to textarea inputs, and introduces the new Key changes:
Issues found:
|
| Filename | Overview |
|---|---|
| src/ui/components/issue_list.rs | Extracts build_issue_list_item/build_issue_list_lines as pub(crate) helpers and adds send_issue_list_preview_for_number; introduces a #![allow(clippy::await_holding_lock)] suppression to hide a real bug where the issue_pool RwLock guard is held across an .await? call when dispatching ChangeIssueBodyPreview. |
| src/ui/components/issue_convo_preview.rs | New component rendering either a body markdown preview (List mode) or a nearby-issues list (Details mode); render_body_preview incorrectly pre-wraps raw markdown with textwrap::wrap before passing it to render_markdown, which can corrupt markdown tokens, and render_issue_list_preview duplicates the sync_selected_issue logic. |
| src/ui/components/label_list.rs | Switches to borderless style (LEFT |
| src/ui/layout.rs | Adds mini_convo_preview field; splits the right panel into three overlapping sections (60%/rest/rest) for the new preview component; shifts main split from 70/30 to 66/34. |
| src/ui/components/issue_conversation.rs | Adds line numbers to the comment input via LineNumberState/LineNumbers; replaces full bordered blocks with single-edge borders; refactors ListPrefix to correctly handle checklist continuation lines; promotes render_markdown, MarkdownRender, and RenderedLink to pub(crate) for use by the new preview component. |
| src/ui/components/issue_detail.rs | Switches IssuePreview block to LEFT |
| src/ui/components/issue_create.rs | Adds line numbers to the body textarea; switches block borders to TOP-only with horizontal padding; dispatches IssueListPreviewUpdated after issue creation. |
| src/ui/mod.rs | Registers IssueConvoPreview as component index 6 and adds ChangeIssueBodyPreview and IssueListPreviewUpdated action variants. |
| src/ui/utils.rs | Changes the default (unfocused) border style to .dim() to reduce visual noise. |
| src/ui/components/status_bar.rs | Fixes a typo in the quit shortcut label: q/<C-q>/<C-c → q/<C-q>/<C-c>; reorders imports. |
| src/ui/testing.rs | Minor modernisation: replaces % n == 0 with is_multiple_of(n) and .min(3).max(1) with .clamp(1, 3); no functional changes. |
Sequence Diagram
sequenceDiagram
participant User
participant IssueList
participant IssueConvoPreview
participant IssueConversation
participant IssuePreview
User->>IssueList: Select issue (Enter)
IssueList->>IssueList: read pool lock
IssueList->>IssueList: resolve body text (pool still locked)
IssueList-->>IssueConvoPreview: ChangeIssueBodyPreview(body) [await while lock held ⚠️]
IssueList->>IssueList: drop pool lock
IssueList-->>IssueConvoPreview: IssueListPreviewUpdated {issue_ids, selected_number}
IssueList-->>IssuePreview: SelectedIssuePreview {seed}
IssueList-->>IssueConversation: EnterIssueDetails {seed}
Note over IssueConvoPreview: List mode → render_body_preview<br/>(pre-wraps markdown with textwrap ⚠️)
Note over IssueConvoPreview: Details mode → render_issue_list_preview<br/>(shows nearby issues window of 5)
User->>IssueConvoPreview: Up/Down (Details mode)
IssueConvoPreview->>IssueConvoPreview: update selected_number
User->>IssueConvoPreview: Enter
IssueConvoPreview-->>IssueConversation: EnterIssueDetails {seed}
Last reviewed commit: "fix(md): fixed check..."
cad7f09 to
f77372e
Compare
1. Removed a lot of unnecessary borders around elements. 2. Added line numbers for the input in issue conversation 3. Added a `BodyPreview` component that shows a preview of the issue body in the TUI list widget. test(ui): update tests chore: fix lints feat(style): migrate over issue_create fix(style): remove old style borders for new ones in textarea previews fix: fix bugs
…ersation fix: render placeholder in create issue mode for convo preview
test(markdown): add UI tests for fixed list rendering
f77372e to
dc565f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

feat(style): Revamp the entire UI to have less borders and distractions
BodyPreviewcomponent that shows a preview of the issuebody in the TUI list widget.
test(ui): update tests