This repository was archived by the owner on Apr 19, 2018. It is now read-only.
Fix crash in layout editor due to ViewPager not set in onMeasure()#335
Open
iTwenty wants to merge 1 commit intoJakeWharton:masterfrom
iTwenty:layout-editor-fix
Open
Fix crash in layout editor due to ViewPager not set in onMeasure()#335iTwenty wants to merge 1 commit intoJakeWharton:masterfrom iTwenty:layout-editor-fix
iTwenty wants to merge 1 commit intoJakeWharton:masterfrom
iTwenty:layout-editor-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to setCurrentItem() in onMeasure() throws an IllegalStateException as the ViewPager is null in editor. This commit fixes this by calling setCurrentItem() only when not in edit mode.