fix: replace jq != operator and add markdownlint troubleshooting#68
fix: replace jq != operator and add markdownlint troubleshooting#68JacobPEvans merged 4 commits intomainfrom
Conversation
- Replace .body != "" with (.body | length > 0) in resolve-pr-threads skills — Claude Code Bash tool escapes ! to \! breaking jq's != operator - Fix bash != in trigger-ai-reviews to avoid same issue - Add markdownlint pre-push hook auto-fix troubleshooting to rebase-pr skill (claude)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two distinct issues: modifying Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5c206ee in 12 seconds. Click for details.
- Reviewed
68lines of code in4files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_jNeyoD0oIIDGT8aZ
You can customize 
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with the != operator in jq and shell scripts by replacing it with equivalent logic, and adds troubleshooting documentation for a pre-push hook edge case. The changes are generally good, but I have a couple of suggestions to improve consistency and code style. In rebase-pr/SKILL.md, the shell variable should be replaced with a placeholder to match the rest of the document. In trigger-ai-reviews/SKILL.md, the conditional logic can be made more concise and idiomatic.
Greptile SummaryFixed Claude Code Bash tool compatibility by replacing
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 5c206ee |
There was a problem hiding this comment.
Pull request overview
Updates several workflow “skills” docs to avoid != where ! can be escaped by Claude Code’s Bash pre-processing, and adds troubleshooting guidance for markdownlint-related hook behavior during pushes.
Changes:
- Rewrites jq filters that used
.body != ""to use(.body | length > 0)in resolve-pr-threads docs. - Adjusts a PR open-state check in trigger-ai-reviews to avoid
!=. - Adds a new rebase-pr edge case section covering pre-push hooks auto-modifying files (e.g., markdownlint on CHANGELOG.md).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| github-workflows/skills/trigger-ai-reviews/SKILL.md | Inverts PR state check to avoid != in the shell test. |
| github-workflows/skills/resolve-pr-threads/rest-api-patterns.md | Replaces jq .body != "" with a length-based non-empty check. |
| github-workflows/skills/resolve-pr-threads/SKILL.md | Same jq filter update + adds troubleshooting row about ! escaping. |
| git-workflows/skills/rebase-pr/SKILL.md | Adds guidance for handling pre-push hooks that modify files mid-push. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ariable
Consistent with all other commands in the skill (lines 83, 99, 108-109, etc.)
which use the {branch} placeholder format.
(claude)
Replace verbose if/else with : # continue body with the standard shell guard clause pattern. Functionally identical, avoids ! character. (claude)
Replace \| (backslash-pipe) inside backtick code spans with | (HTML entity) in the troubleshooting table. The \| notation rendered the backslash visibly in GitHub and produced invalid jq when copy-pasted. The HTML entity renders as a plain | in GitHub markdown while also satisfying markdownlint MD056 (table column count). (claude)
Summary
!=in jq expressions with(.x | length > 0)/ inverted=logic — Claude Code's Bash tool pre-processes commands and escapes!to\!, breaking jq's!=operator. This affectsresolve-pr-threads(2 files) andtrigger-ai-reviews.rebase-prskill — markdownlint pre-push hook can auto-modify CHANGELOG.md, dirtying the working tree mid-push.Test plan
🤖 Generated with Claude Code
Important
Replace
!=in jq expressions and add markdownlint troubleshooting guidance in GitHub workflows.!=in jq expressions with(.x | length > 0)or inverted=logic inresolve-pr-threadsandtrigger-ai-reviewsdue to escaping issues.rebase-pr.resolve-pr-threads/SKILL.mdandrest-api-patterns.md: Update jq expressions.trigger-ai-reviews/SKILL.md: Update logic for PR state check.rebase-pr/SKILL.md: Add edge case for markdownlint auto-fixes.This description was created by
for 5c206ee. You can customize this summary. It will automatically update as commits are pushed.