docs(rebase-pr): add repository prerequisites and ruleset architecture guide#66
docs(rebase-pr): add repository prerequisites and ruleset architecture guide#66JacobPEvans merged 4 commits intomainfrom
Conversation
Document GitHub repository ruleset architecture requirements for the rebase-pr workflow. Key learnings from a real failure case where non_fast_forward and required_linear_history were incorrectly placed on the all-branches ruleset, blocking force-push of rebased feature branches. (claude)
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 25b4144 in 10 seconds. Click for details.
- Reviewed
201lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_BHoNi6prfdwA2oWW
You can customize 
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for the local rebase-merge workflow. It clarifies the reasons for using this workflow over GitHub's native merge options, particularly concerning commit signing and GitHub ruleset compatibility. The updates provide comprehensive guidance on necessary repository configurations, explain how GitHub's Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Document that git push origin main may be blocked by a required CodeQL status check on the main branch ruleset. The force-push in Phase 4 triggers the CodeQL run, but it may not complete before Phase 6. (claude)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is an excellent documentation update that significantly improves the rebase-pr workflow guide. The addition of repository prerequisites, ruleset architecture, and detailed explanations for why certain steps are necessary provides crucial context for users. The new edge cases and anti-patterns, born from a real-world failure, make the documentation much more robust and practical. I have one minor suggestion to enhance clarity in the new ruleset table.
Greptile SummaryThis PR enhances the rebase-pr workflow documentation by adding critical repository prerequisites and edge case handling based on real-world failures. Major additions:
The documentation is comprehensive, technically accurate, and directly addresses the failure scenario mentioned in the PR description (secrets-sync PR #8). All cross-references use proper anchor links and the content follows established markdown conventions. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 0d0d2b3 |
There was a problem hiding this comment.
Pull request overview
Updates the rebase-pr skill documentation to better explain why a local rebase workflow is needed in signature-enforced repos and to document the repository/ruleset prerequisites that make the workflow succeed.
Changes:
- Bump
rebase-prskill version to1.2.0. - Expand rationale section with the GitHub signing limitation and the “push + auto-close” workflow explanation.
- Add “Repository Prerequisites” guidance (local GPG signing config + ruleset scoping) and new edge cases/anti-patterns around force-push and ruleset misconfiguration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rewrites the 609-line skill to ~180 lines. Replaces prose explanations with an ordered sequence of exact commands. Adds ruleset validation guard, condensed GraphQL validation table, and clear Never/Edge Cases sections. Version bumped to 2.0.0. (claude)
Move gpgsign, oneline, worktree, worktrees from inline cspell:words comment to the repo-wide cspell.json custom words list. (claude)
Summary
pull_requestrule works with local rebase (commits auto-associated with open PR)Background
Discovered during a real failure on secrets-sync PR #8: the all-branches ruleset had
non_fast_forwardandrequired_linear_history, which blocked force-push of the rebased feature branch. The fix was scoping those rules to main-only.🤖 Generated with Claude Code
Important
Updates
SKILL.mdwith repository prerequisites, ruleset architecture guide, and additional edge cases for rebase-merge workflow.SKILL.mddetailing local git config and ruleset architecture.pull_requestrule works with local rebase.SKILL.md.This description was created by
for 25b4144. You can customize this summary. It will automatically update as commits are pushed.