Skip to content

feat(finalize-pr): add Phase 4 to auto-update PR metadata#65

Merged
JacobPEvans merged 2 commits intomainfrom
feat/finalize-pr-metadata-update
Mar 2, 2026
Merged

feat(finalize-pr): add Phase 4 to auto-update PR metadata#65
JacobPEvans merged 2 commits intomainfrom
feat/finalize-pr-metadata-update

Conversation

@JacobPEvans
Copy link
Owner

@JacobPEvans JacobPEvans commented Mar 2, 2026

Summary

  • Adds Phase 4 (Update PR Metadata) between pre-handoff verification and the ready report
  • Phase 4 delegates to a haiku subagent for token efficiency — uses compact git log --oneline + git diff --stat instead of full diff
  • Sub-steps 4.1 (title/description) and 4.2 (linked issues/PRs) can run in parallel within the agent
  • Former Phase 4 (Report Ready Status) becomes Phase 5
  • /squash-merge-pr is now marked optional since finalize-pr handles metadata itself

Changes

  • github-workflows/skills/finalize-pr/SKILL.md: Added Phase 4, renumbered Phase 5, updated critical rule 9, updated workflow diagram

Test Plan

  • Read SKILL.md — integer-only phase numbering at top level (1–5)
  • Sub-steps use X.Y notation (4.1, 4.2) and are marked as parallel
  • Workflow diagram matches new 5-phase structure
  • /squash-merge-pr still referenced as optional in Phase 5

🤖 Generated with Claude Code


Important

Adds Phase 4 to finalize-pr for auto-updating PR metadata, making /squash-merge-pr optional, and updates SKILL.md.

  • Behavior:
    • Adds Phase 4 to finalize-pr to auto-update PR metadata (title, description, linked issues) using a haiku subagent.
    • Sub-steps 4.1 (title/description) and 4.2 (linked issues/PRs) run in parallel.
    • Former Phase 4 (Report Ready Status) is now Phase 5.
    • /squash-merge-pr is optional as metadata is handled in Phase 4.
  • Documentation:
    • Updates SKILL.md to include new Phase 4, renumber Phase 5, and update critical rule 9.
    • Updates workflow diagram to reflect 5-phase structure.

This description was created by Ellipsis for b6491de. You can customize this summary. It will automatically update as commits are pushed.

…rting ready

Adds a new Phase 4 between pre-handoff verification and the ready report.
Phase 4 delegates to a haiku subagent (token-efficient) to:
- Update PR title (conventional commit format, <70 chars) and description
  (Summary, Changes, Test Plan) using compact git log/diff --stat output
- Link related issues/PRs via keyword search with Closes #X / Related: #X

Sub-steps 4.1 and 4.2 can run in parallel within the agent. The former
Phase 4 (Report Ready Status) becomes Phase 5. /squash-merge-pr is now
marked as optional since metadata is already updated by finalize-pr.

(claude)
Copilot AI review requested due to automatic review settings March 2, 2026 00:54
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b6491de in 10 seconds. Click for details.
  • Reviewed 108 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_92K27giwQu98gL3e

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the finalize-pr skill documentation to introduce a new Phase 4 that automatically updates PR metadata (title/body and linked issues/PRs) before reporting readiness, shifting the prior “report ready” step to Phase 5.

Changes:

  • Added Phase 4: Update PR Metadata (including parallelizable sub-steps 4.1/4.2 and a final apply step).
  • Renumbered the former Phase 4 (ready report) to Phase 5 and updated the workflow diagram accordingly.
  • Updated the “Critical Rules” to reflect automatic metadata updates and marked /squash-merge-pr as optional.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps
Copy link

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Adds Phase 4 to the finalize-pr skill workflow to automatically update PR metadata (title, description, and linked issues) via a haiku subagent before reporting ready status. The change improves workflow efficiency by handling metadata updates automatically and makes /squash-merge-pr optional since metadata is already prepared.

  • Added Phase 4 with sub-steps 4.1 (title/description) and 4.2 (linked issues) that run in parallel
  • Renumbered former Phase 4 to Phase 5
  • Updated critical rule 9 from "Report ready and pause" to "Update PR metadata automatically"
  • Updated workflow diagram to reflect 5-phase structure
  • Uses token-efficient approach with git log --oneline and git diff --stat instead of full diffs
  • All changes follow repository conventions for integer-only top-level phase numbering and X.Y sub-step notation

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it's a well-structured documentation update that follows all repository conventions
  • Score reflects documentation-only changes with correct phase numbering convention (integers 1-5 for top-level, X.Y for sub-steps), clear parallel execution markers, proper git command syntax, and complete consistency across all updated references (critical rules, phase references, workflow diagram)
  • No files require special attention

Important Files Changed

Filename Overview
github-workflows/skills/finalize-pr/SKILL.md Added Phase 4 for automated PR metadata updates, renumbered Phase 5, and updated critical rule 9 - all changes follow repository conventions

Last reviewed commit: b6491de

… update

- Number 'Apply Updates' as 4.3 to match Phase 2's sub-step convention
- Add git fetch origin main before log/diff to avoid stale ref output
- Switch gh pr edit to --body-file for multiline-safe markdown handling

(claude)
@JacobPEvans JacobPEvans merged commit 1c1e881 into main Mar 2, 2026
5 checks passed
@JacobPEvans JacobPEvans deleted the feat/finalize-pr-metadata-update branch March 2, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants