Conversation
xsscx
approved these changes
Mar 15, 2026
Member
xsscx
left a comment
There was a problem hiding this comment.
Maintainer Review
2026-03-15 02:54:22 UTC
Repro
mkdir pr-695
cd pr-695
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV/Build
git fetch origin pull/695/head:pr-695
git checkout pr-695
export CXX=clang++ && export CXXFLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g -O1 -fprofile-arcs -ftest-coverage" && export LDFLAGS="-fsanitize=address,undefined -fprofile-arcs" && cmake Cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_ASAN=ON -DENABLE_UBSAN=ON -DENABLE_COVERAGE=ON
make -j$(nproc)
cd ../Testing/
echo "=== Updating PATH ==="
for d in ../Build/Tools/*; do
[ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"
done
./CreateAllProfiles.sh
cd ..
iccV5DspObsToV4Dsp Testing/Display/Rec2020rgbSpectral.icc Testing/PCC/Spec400_10_700-D65_2deg-MAT.icc output.icc
PR Application Output
[2026-03-15 02:53:56 UTC] ~/pr-695/iccDEV (pr-695)$ iccV5DspObsToV4Dsp Testing/Display/Rec2020rgbSpectral.icc Testing/PCC/Spec400_10_700-D65_2deg-MAT.icc output.icc
output.icc successfully created
=================================================================
==44064==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 8192 byte(s) in 1 object(s) allocated from:
#0 0x5c55b4e2565d in calloc (/home/h02332/pr-695/iccDEV/Build/Tools/IccV5DspObsToV4Dsp/iccV5DspObsToV4Dsp+0xcc65d) (BuildId: bd0f2eee9b8e77a5fc76de43c54c0f94deaf8850)
#1 0x711ad943198d in CIccTagCurve::CIccTagCurve(int) /home/h02332/pr-695/iccDEV/IccProfLib/IccTagLut.cpp:150:31
#2 0x5c55b4e6792d in main /home/h02332/pr-695/iccDEV/Tools/CmdLine/IccV5DspObsToV4Dsp/IccV5DspObsToV4Dsp.cpp:207:29
#3 0x711ad862a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#4 0x711ad862a28a in __libc_start_main csu/../csu/libc-start.c:360:3
#5 0x5c55b4d8a624 in _start (/home/h02332/pr-695/iccDEV/Build/Tools/IccV5DspObsToV4Dsp/iccV5DspObsToV4Dsp+0x31624) (BuildId: bd0f2eee9b8e77a5fc76de43c54c0f94deaf8850)
...
xsscx
pushed a commit
that referenced
this pull request
Mar 15, 2026
…ate dicts - Fresh cfl branch from master (14 upstream PRs #680-#695) - Retired 8 patches accepted upstream: 003, 010, 011, 018, 019-old, 020, 024, 026 - 17 active patches: 001,002,004-009,014,017,019,021-023,025,028,029 - Consolidated dict/ and dicts/ into single dict/ directory (29 dicts + classified/) - Updated patches/README.md, src/README.md, docs/index.md - All patches verified against master 4df1fe0 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #667
Pull Request Checklist