Skip to content

Fix: Init in iccV5DspObsToV4Dsp#695

Merged
xsscx merged 1 commit intomasterfrom
issue-667
Mar 15, 2026
Merged

Fix: Init in iccV5DspObsToV4Dsp#695
xsscx merged 1 commit intomasterfrom
issue-667

Conversation

@ChrisCoxArt
Copy link
Contributor

Fixes #667

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner March 15, 2026 02:49
@xsscx xsscx self-assigned this Mar 15, 2026
@xsscx xsscx added PR Pull Request Review in Process Issue is being Reviewed by Maintainers and removed pending labels Mar 15, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer Review

2026-03-15 02:54:22 UTC

Repro

mkdir pr-695
cd pr-695
git clone https://github.com/InternationalColorConsortium/iccDEV.git
cd iccDEV/Build
git fetch origin pull/695/head:pr-695
git checkout pr-695
export CXX=clang++ && export CXXFLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer -g -O1 -fprofile-arcs -ftest-coverage" && export LDFLAGS="-fsanitize=address,undefined -fprofile-arcs" && cmake Cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_ASAN=ON -DENABLE_UBSAN=ON -DENABLE_COVERAGE=ON
make -j$(nproc)
        cd ../Testing/
        echo "=== Updating PATH ==="
         for d in ../Build/Tools/*; do
          [ -d "$d" ] && export PATH="$(realpath "$d"):$PATH"
         done
./CreateAllProfiles.sh
cd ..
iccV5DspObsToV4Dsp Testing/Display/Rec2020rgbSpectral.icc Testing/PCC/Spec400_10_700-D65_2deg-MAT.icc output.icc

PR Application Output

[2026-03-15 02:53:56 UTC] ~/pr-695/iccDEV (pr-695)$ iccV5DspObsToV4Dsp Testing/Display/Rec2020rgbSpectral.icc Testing/PCC/Spec400_10_700-D65_2deg-MAT.icc output.icc
output.icc successfully created

=================================================================
==44064==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 8192 byte(s) in 1 object(s) allocated from:
    #0 0x5c55b4e2565d in calloc (/home/h02332/pr-695/iccDEV/Build/Tools/IccV5DspObsToV4Dsp/iccV5DspObsToV4Dsp+0xcc65d) (BuildId: bd0f2eee9b8e77a5fc76de43c54c0f94deaf8850)
    #1 0x711ad943198d in CIccTagCurve::CIccTagCurve(int) /home/h02332/pr-695/iccDEV/IccProfLib/IccTagLut.cpp:150:31
    #2 0x5c55b4e6792d in main /home/h02332/pr-695/iccDEV/Tools/CmdLine/IccV5DspObsToV4Dsp/IccV5DspObsToV4Dsp.cpp:207:29
    #3 0x711ad862a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #4 0x711ad862a28a in __libc_start_main csu/../csu/libc-start.c:360:3
    #5 0x5c55b4d8a624 in _start (/home/h02332/pr-695/iccDEV/Build/Tools/IccV5DspObsToV4Dsp/iccV5DspObsToV4Dsp+0x31624) (BuildId: bd0f2eee9b8e77a5fc76de43c54c0f94deaf8850)
...

@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process Issue is being Reviewed by Maintainers labels Mar 15, 2026
@xsscx xsscx changed the title remove unnecessary and redundant Begin calls Fix: Init in iccV5DspObsToV4Dsp Mar 15, 2026
@xsscx xsscx merged commit 4df1fe0 into master Mar 15, 2026
27 checks passed
@xsscx xsscx removed the Pending Merge Maintainer indicates Merge Pending and requests no further changes label Mar 15, 2026
xsscx pushed a commit that referenced this pull request Mar 15, 2026
…ate dicts

- Fresh cfl branch from master (14 upstream PRs #680-#695)
- Retired 8 patches accepted upstream: 003, 010, 011, 018, 019-old, 020, 024, 026
- 17 active patches: 001,002,004-009,014,017,019,021-023,025,028,029
- Consolidated dict/ and dicts/ into single dict/ directory (29 dicts + classified/)
- Updated patches/README.md, src/README.md, docs/index.md
- All patches verified against master 4df1fe0

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iccV5DspObsToV4Dsp CLI Patch

2 participants